This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH]: XCOFF : Ensure .text/.data file offset == vma % pagesize
- From: Tristan Gingold <gingold at adacore dot com>
- To: Richard Sandiford <rsandifo at linux dot vnet dot ibm dot com>
- Cc: "binutils\ at sourceware dot org Development" <binutils at sourceware dot org>
- Date: Wed, 21 Aug 2013 10:16:31 +0200
- Subject: Re: [PATCH]: XCOFF : Ensure .text/.data file offset == vma % pagesize
- References: <229C7776-28F5-4D9F-9375-E5CE2AB0A3BE at adacore dot com> <87li4oaz82 dot fsf at sandifor-thinkpad dot stglab dot manchester dot uk dot ibm dot com>
Hello,
On Jul 30, 2013, at 4:39 PM, Richard Sandiford <rsandifo@linux.vnet.ibm.com> wrote:
> Sorry for the slow reply. (Seem to be saying that a lot lately.)
No problem (and I was on vacation)
> I was a bit surprised that we didn't have the reloc counts more easily
> available, but I see what you mean.
>
> Tristan Gingold <gingold@adacore.com> writes:
>> + if (info->strip != strip_all)
>> + {
>> + /* There can be additional sections just for dealing with overflow in
>> + reloc and lineno counts. But the numbers of relocs and lineno aren't
>> + known zhen bfd_sizeof_headers is called, so we compute them by
>
> Typo: s/zhen/when/.
Sure
>> + summing the numbers from input sections. */
>> + struct nbr_reloc_lineno
>> + {
>> + unsigned int nbr_relocs;
>> + unsigned int nbr_lineno;
>> + };
>
> Very minor, sorry, but I think the code would be easier to follow if these
> two fields had the same name as the thing they're summing (reloc_count
> and lineno_count).
>
> OK with those changes, thanks. Good spot!
Committed with the suggested change.
Thank you for the review.
Tristan.