This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH][ARM][gas] Accept narrow form of tst<condition> rd, rn in Thumb mode
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, "nickc at redhat dot com" <nickc at redhat dot com>
- Date: Fri, 04 Oct 2013 15:59:03 +0100
- Subject: Re: [PATCH][ARM][gas] Accept narrow form of tst<condition> rd, rn in Thumb mode
- Authentication-results: sourceware.org; auth=none
- References: <524ECEAA dot 3050602 at arm dot com>
On 04/10/13 15:20, Kyrill Tkachov wrote:
> Hi all,
>
> Currently gas fails to assemble:
> .syntax unified
> it gt
> tstgt.n r0, r4
>
> It seems that it's trying to use a 32-bit encoding when it could use a narrow one.
> This patch fixes that. tst doesn't have a "flag setting" variant ("tsts"?) since
> it's already flag setting, therefore in the do_t_mvn_tst function it should be
> treated similarly to cmn.
>
> Tests are added and check-gas passes.
>
> Ok to apply to trunk?
>
> Thanks,
> Kyrill
>
> [gas/]
> 2013-10-04 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * config/tc-arm.c (do_t_mvn_tst): Use narrow form for tst when
> possible.
>
>
> [gas/testsuite/]
> 2013-10-04 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>
> * gas/arm/thumb2_it.s: Add test for narrow tst.
> * gas/arm/thumb2_it.d: Update expected output.
> * gas/arm/thumb2_it_auto.d: Likewise.
>
>
OK.
R.