This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 3/6] x86/MPX: suppress base/index swapping in Intel mode for bndmk, bndldx, and bndstx
- From: "Jan Beulich" <JBeulich at suse dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: <kirill dot yukhin at intel dot com>,"Binutils" <binutils at sourceware dot org>
- Date: Tue, 08 Oct 2013 16:22:58 +0100
- Subject: Re: [PATCH 3/6] x86/MPX: suppress base/index swapping in Intel mode for bndmk, bndldx, and bndstx
- Authentication-results: sourceware.org; auth=none
- References: <5254349502000078000F9A3D at nat28 dot tlf dot novell dot com> <525435E002000078000F9A55 at nat28 dot tlf dot novell dot com> <CAMe9rOqDp1_mAdthvC=kJt_71K4b59kBXEAguGNMBKhrw24Upg at mail dot gmail dot com>
>>> On 08.10.13 at 17:16, "H.J. Lu" <hjl.tools@gmail.com> wrote:
> On Tue, Oct 8, 2013 at 7:42 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> bndmk, bndldx, and bndstx assign special meaning to base and index
>> registers, and hence silently swapping the registers should be
>> suppressed.
>>
>> gas/
>> 2013-10-08 Jan Beulich <jbeulich@suse.com>
>>
>> * tc-i386.c (i386_intel_simplify_register): Suppress base/index
>> swapping for bndmk, bndldx, and bndstx.
>>
>> --- 2013-10-07/gas/config/tc-i386-intel.c
>> +++ 2013-10-07/gas/config/tc-i386-intel.c
>> @@ -291,6 +291,8 @@ i386_intel_simplify_register (expression
>> else if (!intel_state.index)
>> {
>> if (intel_state.in_scale
>> + || current_templates->start->base_opcode == 0xf30f1b /* bndmk */
>> + || (current_templates->start->base_opcode & ~1) == 0x0f1a /* bnd{ld,st}x */
>> || i386_regtab[reg_num].reg_type.bitfield.baseindex)
>> intel_state.index = i386_regtab + reg_num;
>> else
>>
>>
>>
>
> We need a testcase for this.
Which is included in patch 1!
Jan