This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[COMMITTED PATCH] use ATTRIBUTE_UNUSED rather than dummy assignments
- From: Roland McGrath <mcgrathr at google dot com>
- To: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 9 Oct 2013 11:19:08 -0700
- Subject: [COMMITTED PATCH] use ATTRIBUTE_UNUSED rather than dummy assignments
- Authentication-results: sourceware.org; auth=none
Committed as obvious, to trunk and 2.24 branch.
Thanks,
Roland
ld/
2013-10-09 Roland McGrath <mcgrathr@google.com>
* emultempl/elf32.em (id_note_section_size): Use ATTRIBUTE_UNUSED
rather than a dummy assignment for unused parameter.
* plugin.c (get_input_file, release_input_file): Likewise.
--- a/ld/emultempl/elf32.em
+++ b/ld/emultempl/elf32.em
@@ -893,13 +893,11 @@ if test x"$LDEMUL_AFTER_OPEN" !=
xgld"$EMULATION_NAME"_after_open; then
fragment <<EOF
static bfd_size_type
-id_note_section_size (bfd *abfd)
+id_note_section_size (bfd *abfd ATTRIBUTE_UNUSED)
{
const char *style = emit_note_gnu_build_id;
bfd_size_type size;
- abfd = abfd;
-
size = offsetof (Elf_External_Note, name[sizeof "GNU"]);
size = (size + 3) & -(bfd_size_type) 4;
--- a/ld/plugin.c
+++ b/ld/plugin.c
@@ -1,5 +1,5 @@
/* Plugin control for the GNU linker.
- Copyright 2010, 2011, 2012 Free Software Foundation, Inc.
+ Copyright 2010, 2011, 2012, 2013 Free Software Foundation, Inc.
This file is part of the GNU Binutils.
@@ -429,20 +429,18 @@ add_symbols (void *handle, int nsyms, const
struct ld_plugin_symbol *syms)
/* Get the input file information with an open (possibly re-opened)
file descriptor. */
static enum ld_plugin_status
-get_input_file (const void *handle, struct ld_plugin_input_file *file)
+get_input_file (const void *handle ATTRIBUTE_UNUSED,
+ struct ld_plugin_input_file *file ATTRIBUTE_UNUSED)
{
ASSERT (called_plugin);
- handle = handle;
- file = file;
return LDPS_ERR;
}
/* Release the input file. */
static enum ld_plugin_status
-release_input_file (const void *handle)
+release_input_file (const void *handle ATTRIBUTE_UNUSED)
{
ASSERT (called_plugin);
- handle = handle;
return LDPS_ERR;
}