Re: [PATCH] Set CPU type in BFD backend for x86_64-nacl* and i?86-nacl* targets

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Nov 6, 2013 at 4:36 PM, Roland McGrath <mcgrathr@google.com> wrote:
> When I made the NaCl variants in bfd/cpu-i386.c and got the linker to use
> them, I neglected to make them the defaults for the BFD backends so that
> objcopy/strip and the like would use them too.  Changing state in the
> elf_object_p hook seems to be the way this is done, loony as that seems.
>
> Fixing this revealed that I had botched the addition of the
> bfd_mach_i386_nacl bit flag, using the same bit already assigned to
> bfd_mach_l1om (which affects disassembler output).  It also necessitated
> adjusting objdump.c to treat the *_nacl variants like their baselines, and
> loosening some test cases' error message matching to accept the ":nacl"
> variants of the CPU strings.
>
> OK for trunk and 2.24?
>
>
> Thanks,
> Roland
>
>
> bfd/
> 2013-11-06  Roland McGrath  <mcgrathr@google.com>
>
>         * archures.c (bfd_mach_i386_nacl): Fix definition so it doesn't
>         collide with bfd_mach_l1om.
>         * bfd-in2.h: Regenerate.
>
>         * elf32-i386.c (elf32_i386_nacl_elf_object_p): New function.
>         (elf_backend_object_p): Use that in elf32-i386-nacl definition.
>         * elf64-x86-64.c (elf64_x86_64_nacl_elf_object_p): New function.
>         (elf_backend_object_p): Use that in elf64-x86-64-nacl definition.
>         (elf32_x86_64_nacl_elf_object_p): New function.
>         (elf_backend_object_p): Use that in elf32-x86-64-nacl definition.
>
> binutils/
> 2013-11-06  Roland McGrath  <mcgrathr@google.com>
>
>         * objdump.c (dump_dwarf): Grok bfd_mach_x86_64_nacl and
>         bfd_mach_x64_32_nacl as equivalent to bfd_mach_x86_64.
>
> ld/testsuite/
> 2013-11-06  Roland McGrath  <mcgrathr@google.com>
>
>         * ld-x86-64/x86-64.exp (mixed1, mixed2): Loosen error string match
>         so it accepts "i386:nacl" in place of "i386".
>         * ld-x86-64/ilp32-2.d: Likewise.
>         * ld-x86-64/ilp32-3.d: Likewise.
>         * ld-x86-64/lp64-2.d: Likewise.
>         * ld-x86-64/lp64-3.d: Likewise.
>

There are many unrelated changes in objdump.c.
Please remove them and send a separate patch.
OK with this change.

Thanks.


-- 
H.J.