This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, AArch64] Reinstate R_AARCH64_TLS_DTPMOD64, R_AARCH64_TLS_DTPREL64 and R_AARCH64_TLS_TPREL64
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Yufeng Zhang <Yufeng dot Zhang at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Wed, 13 Nov 2013 14:27:33 +0000
- Subject: Re: [PATCH, AArch64] Reinstate R_AARCH64_TLS_DTPMOD64, R_AARCH64_TLS_DTPREL64 and R_AARCH64_TLS_TPREL64
- Authentication-results: sourceware.org; auth=none
- References: <5283893C dot 1030901 at arm dot com>
This is OK.
/M
On 13 November 2013 14:14, Yufeng Zhang <Yufeng.Zhang@arm.com> wrote:
> Hi,
>
> R_AARCH64_TLS_DTPMOD64, R_AARCH64_TLS_DTPREL64 and R_AARCH64_TLS_TPREL64
> were previously renamed to R_AARCH64_TLS_DTPMOD, R_AARCH64_TLS_DTPREL and
> R_AARCH64_TLS_TPREL respectively during the implementation of the ILP32
> support. The latest revision of the AAELF64 document decides to re-instate
> the original relocation names in order to preserve backward-compatibility.
> This patch adds them back. One step beyond the specification,
> R_AAARCH64_TLS_DTPREL, R_AAARCH64_TLS_DTPMOD and R_AAARCH64_TLS_TPREL are
> kept in the current gas/binutils implementation as aliasing names. This
> helps keep the code a bit neat. Note that we have
> R_AAARCH64_P32_TLS_DTPREL, R_AAARCH64_P32_TLS_DTPMOD and
> R_AAARCH64_P32_TLS_TPREL for the corresponding ILP32 ABI.
>
> OK for the mainline and 2_24 branch?
>
> Thanks,
> Yufeng
>
>
> bfd/
>
> * elfnn-aarch64.c (elfNN_aarch64_howto_table): Use
> R_AARCH64_TLS_DTPMOD64 instead of R_AARCH64_TLS_DTPMOD;
> likewise for R_AARCH64_TLS_DTPREL and R_AARCH64_TLS_TPREL.
>
> include/elf/
>
> * include/elf/aarch64.h: Define R_AARCH64_TLS_DTPMOD64,
> R_AARCH64_TLS_DTPREL64 and R_AARCH64_TLS_TPREL64; guard
> R_AARCH64_TLS_DTPMOD, R_AARCH64_TLS_DTPREL and
> R_AARCH64_TLS_TPREL with RELOC_MACROS_GEN_FUNC.