This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [gold] PATCH: Add R_X86_64_PC32_BND and R_X86_64_PLT32_BND
- From: Ian Lance Taylor <iant at google dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>, Cary Coutant <ccoutant at google dot com>
- Date: Mon, 18 Nov 2013 09:51:07 -0800
- Subject: Re: [gold] PATCH: Add R_X86_64_PC32_BND and R_X86_64_PLT32_BND
- Authentication-results: sourceware.org; auth=none
- References: <20131117165613 dot GA17622 at intel dot com> <20131117183518 dot GA5067 at intel dot com> <CAKOQZ8wOAyT9nM0Vbdffdbd=nNXOukm51isoyQqoJTBFxbG+Mw at mail dot gmail dot com> <CAMe9rOr0jgovbPBhe6-qa2TSCNYqmjGeXWhTC6iyaoDmnCkXEA at mail dot gmail dot com>
On Mon, Nov 18, 2013 at 9:24 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Mon, Nov 18, 2013 at 9:15 AM, Ian Lance Taylor <iant@google.com> wrote:
>>
>> I would rather you did a small switch statement setting a local
>> variable rather than nesting ?: expressions.
>
> Like this?
>
> {
> const char *r_name;
> switch (r_type)
> {
> case elfcpp::R_X86_64_32:
> r_name = "R_X86_64_32";
> break;
> case elfcpp::R_X86_64_PC32:
> r_name = "R_X86_64_PC32";
> break;
> case elfcpp::R_X86_64_PC32_BND:
> r_name = "R_X86_64_PC32_BND";
> break;
> default:
> gold_unreachable();
> break;
> }
> object->error(_("requires dynamic %s reloc against '%s' "
> "which may overflow at runtime; recompile "
> "with -fPIC"),
> r_name, gsym->name());
> }
>
Yes, looks good.
Thanks.
Ian