This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] include/gdb/section-scripts.h: New file.


>>>>> "Doug" == Doug Evans <dje@gmail.com> writes:

Doug> This patch creates a file to use when adding values to
Doug> .debug_gdb_scripts.

I don't see why this needs to go in include.

I think it would be more helpful to document the format of this section
in the manual.

Doug> +/* Native GDB scripts are not currently supported in .debug_gdb_scripts,
Doug> +   but we reserve a value for it.  */
Doug> +/*#define SECTION_SCRIPT_ID_GDB_FILE 2*/

There's no need either to reserve a value or to add commented out code.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]