This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR ld/16322: ld fails to generate GNU_RELRO segment
- From: Alan Modra <amodra at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>, Nick Clifton <nickc at redhat dot com>
- Date: Thu, 9 Jan 2014 14:43:04 +1030
- Subject: Re: [PATCH] PR ld/16322: ld fails to generate GNU_RELRO segment
- Authentication-results: sourceware.org; auth=none
- References: <20131212185803 dot GA2434 at intel dot com> <CAMe9rOo+hnJPNUwb3fWqx=HjWvBs+Ekrv+zRgu3F_Rr0KZ1Cjw at mail dot gmail dot com> <CAMe9rOpN28KDu8JzYoaK1b5G12S6DuGAkxOxYnyMk6T2y8iv3A at mail dot gmail dot com>
On Wed, Jan 08, 2014 at 06:01:49AM -0800, H.J. Lu wrote:
> >> + /* If PT_LOAD segment doesn't fit PT_GNU_RELRO segment,
> >> + adjust its p_filesz and p_memsz. */
This is broken. What if there is another LOAD segment following
the one you're adjusting?
> >> if (expld.dataseg.base - (1 << max_alignment_power) < old_base)
> >> expld.dataseg.base += expld.dataseg.pagesize;
> >> - expld.dataseg.base -= (1 << max_alignment_power);
> >> + /* Properly align base to max_alignment_power. */
> >> + expld.dataseg.base &= ~((1 << max_alignment_power) - 1);
> >> lang_reset_memory_regions ();
> >> one_lang_size_sections_pass (relax, check_regions);
This also doesn't look correct to me. Please explain why you think
this is a good idea.
--
Alan Modra
Australia Development Lab, IBM