Re: [Patch,ld] remove ldflags support in ld testsuite

[Vidya Praveen <vidyapraveen at arm dot com>]

Now, with the patch attached! :-)

VP.

On Mon, Jan 13, 2014 at 03:56:29PM +0000, Vidya Praveen wrote:
> Hello,
> 
> This patch removes the recently added support for ldflags in ld testsuite.
> This was earlier added in order to facilitate supplying flags for 'ld' but
> this board config variable is actually meant for ld flags for gcc driver.
> I'll propose a new name for the variable that holds the flags of 'ld' and 
> add support for the same. Until then removing this in order to avoid 
> regressions on other targets.
> 
> OK?
> 
> VP.
> 
> ld/testsuite/ChangeLog:
> 
> 2014-01-13  Vidya Praveen  <vidyapraveen@arm.com>
> 
> 	* lib/ld-lib.exp (default_ld_link): Remove support for ldflags.
> 	(default_ld_simple_link): Likewise.
>

diff --git a/ld/testsuite/lib/ld-lib.exp b/ld/testsuite/lib/ld-lib.exp
index 54b617f..99fb5d8 100644
--- a/ld/testsuite/lib/ld-lib.exp
+++ b/ld/testsuite/lib/ld-lib.exp
@@ -199,10 +199,6 @@ proc default_ld_link { ld target objects } {
 	set flags ""
     }
 
-    if [board_info [target_info name] exists ldflags] {
-        append flags " [board_info [target_info name] ldflags]"
-    }
-
     remote_file host delete $target
 
     return [run_host_cmd_yesno "$ld" "$HOSTING_EMU $flags -o $target $objs $libs"]
@@ -221,10 +217,6 @@ proc default_ld_simple_link { ld target objects } {
 	set flags ""
     }
 
-    if [board_info [target_info name] exists ldflags] {
-        append flags " [board_info [target_info name] ldflags]"
-    }
-
     # If we are compiling with gcc, we want to add gcc_ld_flag to
     # flags.  Rather than determine this in some complex way, we guess
     # based on the name of the compiler.