This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/ARM] Enable Gold to set EF_ARM_HASENTRY attribute on ARM


>> This is a patch for https://sourceware.org/bugzilla/show_bug.cgi?id=16533
>> which enables Gold to set EF_ARM_HASENTRY flag on ARM platforms (to match BFD
>> ld).
>
> Actually you should stop GNU ld from generating it in the EABI case; it's
> not a flag defined by the EABI so should be avoided for new EABI binaries.

As Joseph said, this flag isn't defined by the ARM EABI, so I don't
think we should bother with it. (Is there a reason other than
consistency with Gnu ld that you filed the bug?)

If there is a valid reason for adding the flag, I have a couple of
comments on the patch:

+  EF_ARM_HASENTRY = 0x00000002,

This should be moved up to the top of the enum, before the EABI version flags.

+  if (parameters->entry())
+    this->set_processor_specific_flags(this->processor_specific_flags()
| elfcpp::EF_ARM_HASENTRY);

Line too long. I would do this in do_adjust_elf_header instead of
do_finalize_sections.

-cary


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]