This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH, i386][3/3] Update to match latest AVX512 spec.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 25 Feb 2014 08:03:00 -0800
- Subject: Re: [PATCH, i386][3/3] Update to match latest AVX512 spec.
- Authentication-results: sourceware.org; auth=none
- References: <20140220151936 dot GA1312 at msticlxl7 dot ims dot intel dot com> <CAMe9rOps3fYbJvx0v+6gm2jd=UrDT-0in8adyAUpfQk8AvNy2g at mail dot gmail dot com> <20140224132223 dot GA39232 at msticlxl7 dot ims dot intel dot com> <CAMe9rOqiBVCGAUY-q_HKfnxFVz2tspNCytPNz2mB1hVKrNxajQ at mail dot gmail dot com> <20140225094128 dot GB31394 at msticlxl7 dot ims dot intel dot com> <CAMe9rOrExVo8jbWf_jyefFxoUd0oYXOvdZK4YK5YkEv9Ma4jcQ at mail dot gmail dot com>
On Tue, Feb 25, 2014 at 7:54 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Tue, Feb 25, 2014 at 1:41 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> On 24 Feb 08:30, H.J. Lu wrote:
>>> On Mon, Feb 24, 2014 at 5:22 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>>> > Hi,
>>> >
>>> > Currently support version of vctps2ph with sae and only 1 register
>>> ^^^^^^^^^^^^^^ Please fix
>>> commit log. It should be vcvtps2ph.
>> Fixed.
>>> > operand. This version is encoded as if missing operand was equal to
>>> > ymm0. I didn't found any references to this variant in
>>> > http://download-software.intel.com/sites/default/files/managed/50/1a/319433-018.pdf
>>> > Attached patch removes it. Testing passes. Ok for trunk?
>>>
>>> vcvtps2ph supports memory destination. Please add AVX512F testcases
>>> with memory destination.
>>>
>> We already have such tests. See e. g. on lines 6883-6890 in
>> gas/testsuite/gas/i386/avx512f.s we have:
>>
>> vcvtps2ph $0xab, %zmm6, (%ecx) # AVX512F
>> vcvtps2ph $0xab, %zmm6, (%ecx){%k7} # AVX512F
>> vcvtps2ph $123, %zmm6, (%ecx) # AVX512F
>> vcvtps2ph $123, %zmm6, -123456(%esp,%esi,8) # AVX512F
>> vcvtps2ph $123, %zmm6, 4064(%edx) # AVX512F Disp8
>> vcvtps2ph $123, %zmm6, 4096(%edx) # AVX512F
>> vcvtps2ph $123, %zmm6, -4096(%edx) # AVX512F Disp8
>>
>> Do we need additional tests?
>
> Yes, please test with memory destination for:
>
> vcvtps2ph, 3, 0x661D, None, 1, CpuAVX512F,
> Modrm|EVex=1|Masking=2|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE,
> { Imm8, Imm8, RegZMM|RegMem }
Also for
vcvtps2ph, 4, 0x661D, None, 1, CpuAVX512F,
Modrm|EVex=1|Masking=3|VexOpcode=2|VexW=1|IgnoreSize|No_bSuf|No_wSuf|No_lSuf|No_sSuf|No_qSuf|No_ldSuf|SAE,
{ Imm8, Imm8, RegZMM, RegYMM|RegMem }
--
H.J.