This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] pe/coff: Avoid a crash using objdump -p on the output of objcopy --only-keep-debug
- From: Alan Modra <amodra at gmail dot com>
- To: Jon TURNEY <jon dot turney at dronecode dot org dot uk>
- Cc: Nicholas Clifton <nickc at redhat dot com>, binutils at sourceware dot org
- Date: Wed, 9 Apr 2014 14:07:40 +0930
- Subject: Re: [PATCH 1/2] pe/coff: Avoid a crash using objdump -p on the output of objcopy --only-keep-debug
- Authentication-results: sourceware.org; auth=none
- References: <1395153555-5572-1-git-send-email-jon dot turney at dronecode dot org dot uk> <1395153555-5572-2-git-send-email-jon dot turney at dronecode dot org dot uk> <20140403040236 dot GA4644 at ednor dot casa dot cgf dot cx> <533D45D0 dot 6060703 at redhat dot com> <533EC5EE dot 7040508 at dronecode dot org dot uk> <5343C9B0 dot 1090204 at redhat dot com> <5344428D dot 1010000 at dronecode dot org dot uk>
Fix fallout from splitting ldbuildid.[ch] off elf32.em.
Applied.
bfd/
* libcoff.h: Regenerate.
ld/
* emultempl/spuelf.em: Include safe-ctype.h, remove duplicate errno.h.
* emultempl/nds32elf.em: Include bfd_stdint.h.
* po/POTFILES.in: Regenerate.
diff --git a/bfd/libcoff.h b/bfd/libcoff.h
index 6cb387c..19ba7e7 100644
--- a/bfd/libcoff.h
+++ b/bfd/libcoff.h
@@ -124,7 +124,7 @@ typedef struct pe_tdata
bfd_boolean (*in_reloc_p) (bfd *, reloc_howto_type *);
flagword real_flags;
- /* build-id info. */
+ /* Build-id info. */
struct
{
bfd_boolean (*after_write_object_contents) (bfd *);
diff --git a/ld/emultempl/nds32elf.em b/ld/emultempl/nds32elf.em
index 417eda5..96e6aa3 100644
--- a/ld/emultempl/nds32elf.em
+++ b/ld/emultempl/nds32elf.em
@@ -25,6 +25,7 @@ fragment <<EOF
#include "libbfd.h"
#include "elf-bfd.h"
#include "elf/nds32.h"
+#include "bfd_stdint.h"
#include "elf32-nds32.h"
static int relax_fp_as_gp = 1; /* --mrelax-omit-fp */
diff --git a/ld/emultempl/spuelf.em b/ld/emultempl/spuelf.em
index eaf4de7..5167b35 100644
--- a/ld/emultempl/spuelf.em
+++ b/ld/emultempl/spuelf.em
@@ -447,7 +447,7 @@ EOF
if grep -q 'ld_elf.*ppc.*_emulation' ldemul-list.h; then
fragment <<EOF
-#include <errno.h>
+#include "safe-ctype.h"
#include "filenames.h"
#include "libiberty.h"
diff --git a/ld/po/POTFILES.in b/ld/po/POTFILES.in
index 55cbd13..fcc2894 100644
--- a/ld/po/POTFILES.in
+++ b/ld/po/POTFILES.in
@@ -3,6 +3,8 @@ elf-hints-local.h
emultempl/armcoff.em
emultempl/pe.em
ld.h
+ldbuildid.c
+ldbuildid.h
ldcref.c
ldctor.c
ldctor.h
--
Alan Modra
Australia Development Lab, IBM