This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Allow copy relocations with pie links
- From: Cary Coutant <ccoutant at google dot com>
- To: Sriraman Tallam <tmsriram at google dot com>
- Cc: David Miller <davem at davemloft dot net>, walt at tilera dot com, Doug Kwan <dougkwan at google dot com>, binutils <binutils at sourceware dot org>, Ian Lance Taylor <iant at google dot com>, David Li <davidxl at google dot com>
- Date: Tue, 13 May 2014 09:52:14 -0700
- Subject: Re: Allow copy relocations with pie links
- Authentication-results: sourceware.org; auth=none
- References: <CAAs8HmxwPuH7_s1yLxeW_6qkMCB+_kYSzB6yYG85QZS6yVHpZg at mail dot gmail dot com> <CAHACq4q9qP_h=PuwhJkE6KMt_xf6_Ne3unGRdQpvFqaXL=OxPw at mail dot gmail dot com> <CAAs8HmxkGVYAyq4wf1FChqowmQRTO9POve8Ve5f4kb3DXPfywQ at mail dot gmail dot com> <CAHACq4qx-C-W06-2oYtHz6uVuF3WHyFfp7AO9epk84Y9_6PLOA at mail dot gmail dot com> <20140508231602 dot GC5162 at bubble dot grove dot modra dot org> <CAHACq4oTU7tV+8_5Z_iJ=J2=8tWObXKRP1KL=sSpM-vhbHsnaw at mail dot gmail dot com> <20140509010830 dot GD5162 at bubble dot grove dot modra dot org> <CAHACq4r0jZsfo6WZznFjSibBGLtPs=WXrme+0LWgomrmWgTEOg at mail dot gmail dot com> <CAAs8Hmy6KkPCA-dczbDPMObpDi8HBZXy87pgbLdqbwAQn-rSxA at mail dot gmail dot com>
> Changed and patch attached.
* symtab.h (may_need_copy_reloc): Remove check for position independent
code.
* x86_64.cc (Target_x86_64<size>::Scan::global): Add check for no
position independence before pc absolute may_need_copy_reloc call.
Add check for executable output befor pc relative may_need_copy_reloc
call.
* i386.cc: Ditto.
* arm.cc: Ditto.
* sparc.cc: Ditto.
* tilegx.cc: Ditto.
* powerpc.cc: Add check for no position independence before
may_need_copy_reloc calls.
* testsuite/pie_copyrelocs_test.cc: New file.
* testsuite/pie_copyrelocs_shared_test.cc: New file.
* Makefile.am (pie_copyrelocs_test): New test.
* Makefile.in: Regenerate.
This is OK to commit now -- I think it's safe for ARM and tilegx. Thanks!
-cary