Re: [PATCH v2] Add support for O32 FPXX ABI

[Richard Sandiford <rdsandiford at googlemail dot com>]

Matthew Fortune <Matthew.Fortune@imgtec.com> writes:
> On the topic of the testsuites (in particular the linker). Do you have
> any strong feelings as to whether I should always just update the
> expected output if affected by the introduction of .gnu.attributes,
> .MIPS.abiflags or the PT_MIPS_ABIFLAGS header? The alternative (for some
> tests) is to modify the link script to just discard .gnu.attributes and
> .MIPS.abiflags.
>
> I'd like to do a bit of both personally. The program header and
> .MIPS.abiflags section will be checked at least once for each ABI though
> of course.

Yeah, good question...  When doing linker tests, I've tried to make
the linker script fairly tolerant against this kind of thing, e.g. with:

SECTIONS
{
  . = 0x40000 + SIZEOF_HEADERS;
  .interp : { *(.interp) }

  . = 0x41000;
  .reginfo : { *(.reginfo) }
  .hash : { *(.hash) }
  .dynsym : { *(.dynsym) }
  .dynstr : { *(.dynstr) }

  . = 0x42000;
  .dynamic : { *(.dynamic) }

  . = 0x43000;
  .rel.dyn : { *(.rel.dyn) }
  .rel.plt : { *(.rel.plt) }
  .plt : { *(.plt) }

  . = 0x44000;
  .text : { *(.text) }
  .MIPS.stubs : { *(.MIPS.stubs) }
  .MIPS.options : { *(.MIPS.options) }

  . = 0x80000;
  .rld_map : { *(.rld_map) }

  . = 0x81000;
  .got.plt : { *(.got.plt) }

  . = 0xa0000;
  HIDDEN (_gp = . + 0x7ff0);
  .got : { *(.got) }

  . = 0xa1000;
  .data : { *(.data) }

  . = 0xa2000;
  .bss : { *(.dynbss) }
}

But I suppose even that isn't going to help for something that goes
immediately after the headers.

So yeah, discarding .MIPS.abiflags where easiest is fine with me.
Not sure about .gnu_attributes though.  I thought that would never
become loadable under the new scheme.

Thanks,
Richard