This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[gold commit] Fix testsuite problem with ehdr_start_test_4
- From: Cary Coutant <ccoutant at google dot com>
- To: Binutils <binutils at sourceware dot org>
- Cc: Alan Modra <amodra at gmail dot com>
- Date: Fri, 30 May 2014 10:26:29 -0700
- Subject: [gold commit] Fix testsuite problem with ehdr_start_test_4
- Authentication-results: sourceware.org; auth=none
In the gold testsuite, ehdr_start_test_4 was being built with the
build system linker instead of the under-test linker. As a consequence
of that, the check script was looking for the wrong result from
running nm on the binary. This patch fixes both problems.
-cary
2014-05-30 Cary Coutant <ccoutant@google.com>
gold/
* testsuite/Makefile.am (ehdr_start_test_4): Fix typo in -B option.
* testsuite/Makefile.in: Regenerate.
* testsuite/ehdr_start_test_4.sh: Look for "U" instead of "w".
diff --git a/gold/testsuite/Makefile.am b/gold/testsuite/Makefile.am
index 0373464..379ac8a 100644
--- a/gold/testsuite/Makefile.am
+++ b/gold/testsuite/Makefile.am
@@ -2241,7 +2241,7 @@ MOSTLYCLEANFILES += ehdr_start_test_4
ehdr_start_test_4.syms: ehdr_start_test_4
$(TEST_NM) ehdr_start_test_4 > $@
ehdr_start_test_4: ehdr_start_test_4.o gcctestdir/ld
- $(CXXLINK) -Bgcctestdir/ld/ -Wl,-Ttext=0x100100 $<
+ $(CXXLINK) -Bgcctestdir/ -Wl,-Ttext=0x100100 $<
ehdr_start_test_4.o: ehdr_start_test.cc
$(CXXCOMPILE) -c -DEHDR_START_WEAK -o $@ $<
diff --git a/gold/testsuite/ehdr_start_test_4.sh
b/gold/testsuite/ehdr_start_test_4.sh
index ad0a5a7..5e3d20f 100755
--- a/gold/testsuite/ehdr_start_test_4.sh
+++ b/gold/testsuite/ehdr_start_test_4.sh
@@ -35,6 +35,6 @@ check()
fi
}
-check ehdr_start_test_4.syms "w __ehdr_start"
+check ehdr_start_test_4.syms "U __ehdr_start"
exit 0