This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Mips target in gold - revision 3 - part 2
- From: Alan Modra <amodra at gmail dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Sasa Stankovic <Sasa dot Stankovic at imgtec dot com>, Rich Fuhler <Rich dot Fuhler at imgtec dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>, Heiher <admin at heiher dot info>
- Date: Thu, 26 Jun 2014 11:44:18 +0930
- Subject: Re: Mips target in gold - revision 3 - part 2
- Authentication-results: sourceware.org; auth=none
- References: <7EDC79CE48A9944A88968ABABE6038EE6D41C348 at BADAG02 dot ba dot imgtec dot org> <CAHACq4qGRR4=UaD3dPafHnZmjMF+ig2my79Dwo6wNwZnq9W1-g at mail dot gmail dot com> <7EDC79CE48A9944A88968ABABE6038EE6DF1F4DF at BADAG02 dot ba dot imgtec dot org> <7EDC79CE48A9944A88968ABABE6038EE6DF1F50A at BADAG02 dot ba dot imgtec dot org> <CAHACq4oXfDpvJrf0N0o+c2KGQN1kJx=QqjEvpO7VH-5GPPZohA at mail dot gmail dot com>
On Mon, Jun 23, 2014 at 12:10:10PM -0700, Cary Coutant wrote:
> I've committed these changes on your behalf.
>
> I also included a small fix to configure.tgt (thanks to
> admin@heiher.info), which moves the catch-all "mips*-*-*" case below
> the more specific "mips*el*-*-*|mips*le*-*-*" case.
>
> Gold now support MIPS! Thanks for all the work on this!
mips.o: In function `emit_entry':
/src/binutils-gdb/gold/mips.cc:7162: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
mips.o: In function `emit':
/src/binutils-gdb/gold/mips.cc:3461: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
mips.o: In function `count_got_symbols':
/src/binutils-gdb/gold/mips.cc:5275: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
/src/binutils-gdb/gold/mips.cc:5275: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
/src/binutils-gdb/gold/mips.cc:5275: undefined reference to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const'
mips.o:/src/binutils-gdb/gold/mips.cc:5977: more undefined references to `gold::Symbol::should_add_dynsym_entry(gold::Symbol_table*) const' follow
OK to apply?
* symtab.cc (Symbol::should_add_dynsym_entry): Don't make inline.
diff --git a/gold/symtab.cc b/gold/symtab.cc
index 4e8afb1..b329bb6 100644
--- a/gold/symtab.cc
+++ b/gold/symtab.cc
@@ -334,7 +334,7 @@ Sized_symbol<size>::allocate_common(Output_data* od, Value_type value)
// Return true if this symbol should be added to the dynamic symbol
// table.
-inline bool
+bool
Symbol::should_add_dynsym_entry(Symbol_table* symtab) const
{
// If the symbol is only present on plugin files, the plugin decided we
--
Alan Modra
Australia Development Lab, IBM