This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix handling of common symbols with plugins
- From: Cary Coutant <ccoutant at google dot com>
- To: Rafael EspÃndola <rafael dot espindola at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 17 Sep 2014 10:17:26 -0700
- Subject: Re: [patch] Fix handling of common symbols with plugins
- Authentication-results: sourceware.org; auth=none
- References: <CAG3jRe+9-c3erPGakOydZfpEZAD5Fw=bEP1EV7MyFFp33wApQQ at mail dot gmail dot com>
> gold
> 2014-09-09 Rafael Ãvila de EspÃndola <respindola@mozilla.com>
>
> * plugin.cc (Sized_pluginobj::do_add_symbols): Ignore isym->size.
> * resolve.cc (Symbol_table::resolve): Don't override common symbols
> during the replacement phase.
The gold patch looks good to me. Thanks!
> include
> 2014-09-09 Rafael Ãvila de EspÃndola <respindola@mozilla.com>
>
> * plugin-api.h (ld_plugin_symbol): Note that size is ignored.
This is OK if the ld patch is also approved.
> ld
> 2014-09-09 Rafael Ãvila de EspÃndola <respindola@mozilla.com>
>
> * plugin.c (asymbol_from_plugin_symbol): Ignore ldsym->size.
> * testplug.c (parse_symdefstr): Ignore sym->size.
Maybe HJ should look at this?
-cary