This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix handling of common symbols with plugins
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Rafael EspÃndola <rafael dot espindola at gmail dot com>
- Cc: Cary Coutant <ccoutant at google dot com>, Binutils <binutils at sourceware dot org>
- Date: Thu, 18 Sep 2014 07:43:07 -0700
- Subject: Re: [patch] Fix handling of common symbols with plugins
- Authentication-results: sourceware.org; auth=none
- References: <CAG3jRe+9-c3erPGakOydZfpEZAD5Fw=bEP1EV7MyFFp33wApQQ at mail dot gmail dot com> <CAHACq4oaSAUUpn08eFfN488kSa8J9pkKxTEQgzKR5Z8KbbWMkQ at mail dot gmail dot com> <CAMe9rOqKLp-T2SUgMU3x2j22f-AtG7z1H9nvQoNB36SHbCEhvA at mail dot gmail dot com> <CAG3jReKk0XOEKzSo598NugCHn2A3GygKBc4ZCi7hodg6NEJnDw at mail dot gmail dot com>
On Wed, Sep 17, 2014 at 3:36 PM, Rafael EspÃndola
<rafael.espindola@gmail.com> wrote:
>>> The gold patch looks good to me. Thanks!
>
> Pushed.
>
>> Can you add an ld testcase to ld/testsuite/ld-plugin/lto.exp?
>
> I don't think my patch changes the behavior of bfd-l, it is just a
> cleanup. I applied Hal Finkel's patch to let ld work with llvm IR and
> it passes the run.sh that I emailed earlier with or without my patch.
If it has no impact on your testcase, I prefer to leave ld alone.
> Having said that, while the size field is not useful for common
> symbols, it might be just what is needed for coff's
> COMDAT_SELECT_LARGEST. Do you know if that is implemented?
>
The ELF ld will always use the largest alignment and sizes for
the common symbol.
--
H.J.