This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix handling of common symbols with plugins
- From: Alan Modra <amodra at gmail dot com>
- To: Cary Coutant <ccoutant at google dot com>
- Cc: Rafael Espíndola <rafael dot espindola at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Sat, 27 Sep 2014 12:23:04 +0930
- Subject: Re: [patch] Fix handling of common symbols with plugins
- Authentication-results: sourceware.org; auth=none
- References: <CAG3jRe+9-c3erPGakOydZfpEZAD5Fw=bEP1EV7MyFFp33wApQQ at mail dot gmail dot com> <CAHACq4oaSAUUpn08eFfN488kSa8J9pkKxTEQgzKR5Z8KbbWMkQ at mail dot gmail dot com> <CAMe9rOqKLp-T2SUgMU3x2j22f-AtG7z1H9nvQoNB36SHbCEhvA at mail dot gmail dot com> <CAG3jReKk0XOEKzSo598NugCHn2A3GygKBc4ZCi7hodg6NEJnDw at mail dot gmail dot com> <CAHACq4qWKupZWbHb8yvZJ+GTY=3dkgj9MyU8RB0PCq13Vx-Z+A at mail dot gmail dot com> <CAG3jRe+ZADmyrD4PMGosBFtpP1faWE4C+_A26Bfw6OpZgopxpg at mail dot gmail dot com> <CAG3jReK3R_PUrV+Fzt9Z12hmVDKbmzvKe6dscrNOM1OrvGHy_g at mail dot gmail dot com> <CAHACq4rDn-+6sg25c2zQBJNDjW=NrrO_gdeAxtxCPbtLZnHxEg at mail dot gmail dot com>
On Thu, Sep 18, 2014 at 10:09:06AM -0700, Cary Coutant wrote:
> >> 2014-09-18 Rafael Ávila de Espíndola <rafael.espindola@gmail.com>
> >>
> >> * testsuite/Makefile.am (plugin_test_10): New test.
> >> * testsuite/Makefile.in: Regenerate
> >> * testsuite/plugin_common_test_2.c (c1): Align to 8.
> >> * testsuite/plugin_test_10.sh: New file.
>
> This is OK. Thanks!
Fails on x86_64 when using mainline gcc. c1 is aligned (value = 8) in
the relocatable object file
20: 0000000000000008 4 OBJECT GLOBAL DEFAULT COM c1
plugin_common_test_1.syms:
23: 0000000000000004 4 OBJECT GLOBAL DEFAULT COM c1
Final object file:
39: 0000000000401b7c 4 OBJECT GLOBAL DEFAULT 25 c1
and .bss only has an alignment of 4.
--
Alan Modra
Australia Development Lab, IBM