This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gdb/c-lang.c: Remove useless "err = 0;" instruction in c_get_string()
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Chen Gang <gang dot chen dot 5i5j at gmail dot com>
- Cc: amodra at gmail dot com, Pedro Alves <palves at redhat dot com>, gbenson at redhat dot com, dje at google dot com, gdb-patches at sourceware dot org, binutils at sourceware dot org
- Date: Sat, 27 Sep 2014 17:46:47 -0700
- Subject: Re: [PATCH] gdb/c-lang.c: Remove useless "err = 0;" instruction in c_get_string()
- Authentication-results: sourceware.org; auth=none
- References: <54267F0D dot 3070409 at gmail dot com>
> 'err' only has effect within a code block, so declare it within the code
> block, and remove useless "err = 0;" instruction.
>
> gdb/
> 2014-09-27 Chen Gang <gang.chen.5i5j@gmail.com>
>
> * c-lang.c (c_get_string): Remove useless "err = 0;" instruction.
Looks good to me. Go ahead and push.
--
Joel