This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Don't sign extend the addend for R_MIPS_PC16 and R_MIPS_GNU_REL16_S2 if relocations are RELA
- From: "Maciej W. Rozycki" <macro at codesourcery dot com>
- To: Andrew Bennett <Andrew dot Bennett at imgtec dot com>
- Cc: Richard Sandiford <rdsandiford at googlemail dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Mon, 29 Sep 2014 14:58:43 +0100
- Subject: Re: [PATCH] Don't sign extend the addend for R_MIPS_PC16 and R_MIPS_GNU_REL16_S2 if relocations are RELA
- Authentication-results: sourceware.org; auth=none
- References: <0DA23CC379F5F945ACB41CF394B9827720EE0411 at LEMAIL01 dot le dot imgtec dot org> <87tx4bx5v6 dot fsf at googlemail dot com> <0DA23CC379F5F945ACB41CF394B9827720EE12DC at LEMAIL01 dot le dot imgtec dot org> <87egv4ocka dot fsf at googlemail dot com>
On Sun, 21 Sep 2014, Richard Sandiford wrote:
> Andrew Bennett <Andrew.Bennett@imgtec.com> writes:
> > bfd/
> > * elfxx-mips.c (mips_elf_calculate_relocation): Don't sign extend
> > the addend if relocations are RELA.
>
> OK, thanks, and sorry for the slow review.
Any chance for test cases to cover the bug? From the nature of the
problem it looks to me they should be straightforward to make.
Maciej