This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix handling of common symbols with plugins
- From: Cary Coutant <ccoutant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>, Rafael EspÃndola <rafael dot espindola at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Mon, 29 Sep 2014 10:21:44 -0700
- Subject: Re: [patch] Fix handling of common symbols with plugins
- Authentication-results: sourceware.org; auth=none
- References: <CAG3jRe+9-c3erPGakOydZfpEZAD5Fw=bEP1EV7MyFFp33wApQQ at mail dot gmail dot com> <CAHACq4oaSAUUpn08eFfN488kSa8J9pkKxTEQgzKR5Z8KbbWMkQ at mail dot gmail dot com> <CAMe9rOqKLp-T2SUgMU3x2j22f-AtG7z1H9nvQoNB36SHbCEhvA at mail dot gmail dot com> <CAG3jReKk0XOEKzSo598NugCHn2A3GygKBc4ZCi7hodg6NEJnDw at mail dot gmail dot com> <CAHACq4qWKupZWbHb8yvZJ+GTY=3dkgj9MyU8RB0PCq13Vx-Z+A at mail dot gmail dot com> <CAG3jRe+ZADmyrD4PMGosBFtpP1faWE4C+_A26Bfw6OpZgopxpg at mail dot gmail dot com> <CAG3jReK3R_PUrV+Fzt9Z12hmVDKbmzvKe6dscrNOM1OrvGHy_g at mail dot gmail dot com> <CAHACq4rDn-+6sg25c2zQBJNDjW=NrrO_gdeAxtxCPbtLZnHxEg at mail dot gmail dot com> <20140927025304 dot GB27380 at bubble dot grove dot modra dot org>
Is this still failing even after my patch last Thursday for PR
gold/17432? Or did it only start failing after that patch?
I see 8 in the value field in the .syms file, and an alignment of 8 on
.bss in the executable.
> Fails on x86_64 when using mainline gcc. c1 is aligned (value = 8) in
> the relocatable object file
> 20: 0000000000000008 4 OBJECT GLOBAL DEFAULT COM c1
That looks like a dump of plugin_common_test_2.o.
> plugin_common_test_1.syms:
> 23: 0000000000000004 4 OBJECT GLOBAL DEFAULT COM c1
But this is from plugin_common_test_1.o. I expect
plugin_common_test_1.syms to have an alignment of 4.
> Final object file:
> 39: 0000000000401b7c 4 OBJECT GLOBAL DEFAULT 25 c1
> and .bss only has an alignment of 4.
Is this from plugin_test_10?
Here's what I see:
$ grep c1 plugin_common_test_2.syms
17: 0000000000000008 4 OBJECT GLOBAL DEFAULT COM c1
$ readelf -SW plugin_test_10 | grep \\.bss
[26] .bss NOBITS 0000000000401c30 000c30
00001c 00 WA 0 0 8
$ readelf -sW plugin_test_10 | grep c1
51: 0000000000401c40 4 OBJECT GLOBAL DEFAULT 26 c1
-cary