This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Fix handling of common symbols with plugins
- From: Cary Coutant <ccoutant at google dot com>
- To: Cary Coutant <ccoutant at google dot com>, Rafael EspÃndola <rafael dot espindola at gmail dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Tue, 30 Sep 2014 16:01:19 -0700
- Subject: Re: [patch] Fix handling of common symbols with plugins
- Authentication-results: sourceware.org; auth=none
- References: <CAHACq4oaSAUUpn08eFfN488kSa8J9pkKxTEQgzKR5Z8KbbWMkQ at mail dot gmail dot com> <CAMe9rOqKLp-T2SUgMU3x2j22f-AtG7z1H9nvQoNB36SHbCEhvA at mail dot gmail dot com> <CAG3jReKk0XOEKzSo598NugCHn2A3GygKBc4ZCi7hodg6NEJnDw at mail dot gmail dot com> <CAHACq4qWKupZWbHb8yvZJ+GTY=3dkgj9MyU8RB0PCq13Vx-Z+A at mail dot gmail dot com> <CAG3jRe+ZADmyrD4PMGosBFtpP1faWE4C+_A26Bfw6OpZgopxpg at mail dot gmail dot com> <CAG3jReK3R_PUrV+Fzt9Z12hmVDKbmzvKe6dscrNOM1OrvGHy_g at mail dot gmail dot com> <CAHACq4rDn-+6sg25c2zQBJNDjW=NrrO_gdeAxtxCPbtLZnHxEg at mail dot gmail dot com> <20140927025304 dot GB27380 at bubble dot grove dot modra dot org> <CAHACq4q7txD0+ynrW+q1+RvtLZbSc_JddXZdQMyv_wnrY5ti-g at mail dot gmail dot com> <20140930022030 dot GA5350 at bubble dot grove dot modra dot org> <20140930041443 dot GB5350 at bubble dot grove dot modra dot org>
> Oops, wrong commit. The patch that causes the failure is the one you
> suspected, 1707f183, your PR 17432 change.
It was a cut-and-paste error on my part, sorry! This should fix it...
-cary
diff --git a/gold/resolve.cc b/gold/resolve.cc
index 52dae8b..07dff4a 100644
--- a/gold/resolve.cc
+++ b/gold/resolve.cc
@@ -317,8 +317,8 @@ Symbol_table::resolve(Sized_symbol<size>* to,
if (to->is_common() && !is_ordinary && st_shndx == elfcpp::SHN_COMMON)
{
adjust_common = true;
- typename Sized_symbol<size>::Size_type tosize = to->symsize();
- typename Sized_symbol<size>::Value_type tovalue = to->value();
+ tosize = to->symsize();
+ tovalue = to->value();
}
this->override(to, sym, st_shndx, is_ordinary, object, version);
if (adjust_common)