This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, MIPS] When calculating a relocation using an undefined weak symbol don't check for overflow.


On Tue, Dec 02, 2014 at 01:40:03PM +0000, Andrew Bennett wrote:
> > > bfd/
> > > 	* elfxx-mips.c (mips_elf_calculate_relocation): Only check for overflow
> > > 	on non-weak undefined symbols.
> > >
> > > ld/testsuite/
> > > 	* ld-mips-elf/mips-elf.exp: Add in undefined weak overflow tests for
> > > 	o32, n32 and n64.
> > > 	* ld-mips-elf/undefweak-overflow.s: New test.
> > > 	* ld-mips-elf/undefweak-overflow.d: New test.
> > > 	* ld-mips-elf/undefweak-overflow-n64.d: New test.
> > > 	* ld-mips-elf/undefweak-overflow-n64.d: New test.
> > 
> > OK, thanks, and sorry for the slow reply.
> 
> That's ok.  I have now committed the patch.

mipsisa32el-linux  +FAIL: undefined weak symbol overflow (n32)
mipsisa32el-linux  +FAIL: undefined weak symbol overflow (n64)
tx39-elf  +FAIL: undefined weak symbol overflow

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]