This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC] Add support for printing pdata for x86_64 pe coff objects
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Nicholas Clifton <nickc at redhat dot com>
- Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, Binutils <binutils at sourceware dot org>
- Date: Wed, 24 Dec 2014 14:16:34 -0800
- Subject: Re: [RFC] Add support for printing pdata for x86_64 pe coff objects
- Authentication-results: sourceware.org; auth=none
- References: <5499A8D3 dot 4090900 at redhat dot com>
On Tue, Dec 23, 2014 at 9:39 AM, Nicholas Clifton <nickc@redhat.com> wrote:
> Hi Pierre,
>
>> bfd/ChangeLog entry:
>>
>> 2014-10-01 Pierre Muller <muller@sourceware.org>
>>
>> Add support for pdata output for pe coff objects.
>> * pe-x86_64.c (pex64_bfd_print_pdata): Add external
>> declaration.
>> (bfd_pe_print_data): Set macro to pex64_bfd_print_data.
>> * pei-x86_64.c (pex64_bfd_print_pdata): Changed to
>> global function. Now handles multiple .pdata sections.
>> (pex_bfd_print_pdata_section): New static helper function,
>> using most of old pex_bfd_print_pdata function code, but adding
>> support for coff pe objects, which might have some fields
>> starting at zero offset.
>> (pex64_print_all_pdata_sections) : New static helper function,
>> used in call to bfd_map_over_sections inside new
>> pex66_bfd_print_pdata function.
>> (bfd_boolean pdata_count): New static variable, used to return
>> bfd_boolean value for pex64_bfd_print_pdata function.
>
>
> Approved - please apply.
>
> Sorry for the long delay in reviewing.
I checked in this for 32-bit hosts.
--
H.J.
----
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index af3fe44..c85bd07 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2014-12-24 H.J. Lu <hongjiu.lu@intel.com>
+
+ * pei-x86_64.c (pex64_bfd_print_pdata_section): Add cast to
+ unsigned long.
+
2014-12-24 Pierre Muller <muller@sourceware.org>
Add support for pdata output for pe coff objects.
diff --git a/bfd/pei-x86_64.c b/bfd/pei-x86_64.c
index 16d8899..51bf390 100644
--- a/bfd/pei-x86_64.c
+++ b/bfd/pei-x86_64.c
@@ -509,7 +509,8 @@ pex64_bfd_print_pdata_section (bfd *abfd, void
*vfile, asection *pdata_section)
{
fprintf (file,
_("Warning: %s section size (%ld) is smaller than virtual size (%ld)\n"),
- pdata_section->name, datasize, stop);
+ pdata_section->name, (unsigned long) datasize,
+ (unsigned long) stop);
/* Be sure not to read passed datasize. */
stop = datasize / onaline;
}