This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: PR ld/14272: Mark the plugin symbol undefined
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>, Binutils <binutils at sourceware dot org>
- Date: Wed, 4 Feb 2015 04:36:16 -0800
- Subject: Re: PATCH: PR ld/14272: Mark the plugin symbol undefined
- Authentication-results: sourceware.org; auth=none
- References: <20120628221026 dot GA5008 at intel dot com> <CAMe9rOqVkDWQ3gzojEQzRLmcj=DC+a9GS5HWX2Zy9S7HD9QkBA at mail dot gmail dot com> <20150204110841 dot GN14796 at bubble dot grove dot modra dot org>
On Wed, Feb 4, 2015 at 3:08 AM, Alan Modra <amodra@gmail.com> wrote:
> On Tue, Feb 03, 2015 at 09:06:47AM -0800, H.J. Lu wrote:
>> PR ld/12365
>> * ld-plugin/pr12365a.c: New file.
>> * ld-plugin/pr12365b.c: Likewise.
>> * ld-plugin/pr12365c.c: Likewise.
>
> The testcase fails when using gcc-5. Also, gcc-5 objects don't seem
> exercise your _bfd_elf_fix_symbol_flags code. I presume you need an
> older version of gcc, with lto bugs, to need those hacks. Is that
> true? Can you write a testcase that does exercise your
> _bfd_elf_fix_symbol_flags code?
>
The -flto-partition default was changed. I checked in this patch
to pass -flto-partition=none to the PR ld/12365 test.
--
H.J.
----
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index 876bafa..1041bd1 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-04 H.J. Lu <hongjiu.lu@intel.com>
+
+ * ld-plugin/lto.exp: Pass -flto-partition=none to the PR
+ ld/12365 test.
+
2015-02-03 H.J. Lu <hongjiu.lu@intel.com>
PR ld/12365
diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp
index 400e683..065e1bb 100644
--- a/ld/testsuite/ld-plugin/lto.exp
+++ b/ld/testsuite/ld-plugin/lto.exp
@@ -384,7 +384,7 @@ if {![string match "" $catch_output]} {
if { [at_least_gcc_version 4 7] } {
# Check expected LTO linker errors.
set testname "PR ld/12365"
- set exec_output [run_host_cmd "$CC" "-O2 -flto
-fuse-linker-plugin tmpdir/pr12365a.o tmpdir/pr12365b.o
tmpdir/pr12365c.o"]
+ set exec_output [run_host_cmd "$CC" "-O2 -flto
-flto-partition=none -fuse-linker-plugin tmpdir/pr12365a.o
tmpdir/pr12365b.o tmpdir/pr12365c.o"]
if { [ regexp "undefined reference to `my_bcopy'" $exec_output ] } {
pass $testname
} {