This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: [PATCH] Support -plugin-opt=disable-output for LLVM plugin


On Wed, Feb 11, 2015 at 5:15 PM, Rafael EspÃndola
<rafael.espindola@gmail.com> wrote:
> On 11 February 2015 at 20:06, H.J. Lu <hjl.tools@gmail.com> wrote:
>> On Wed, Feb 11, 2015 at 4:52 PM, Rafael EspÃndola
>> <rafael.espindola@gmail.com> wrote:
>>> I would be happy to transition the plugin to an exit callback if that
>>> was supported by both bfd and gold.
>>
>> I don't know if we have one for both ld and gold.
>
> I don't think gold has one, but if it was added we could transition to
> it by calling the exit callback if provided or the libc exit if not.

You can use atexit.  It is used elsewhere in llvm.

>
>> BTW, the enclosed patch for lllvm is needed for ld.
>
> I think it is OK. Can you email it to llvm-commits?
>

Done.

gold-plugin tests have 2 issues:

1. It expects gold:

    ld_version = subprocess.Popen(['ld', '--version'], stdout = subprocess.PIPE)
    if not 'GNU gold' in ld_version.stdout.read():
        return False

2. It expects elf32ppc support:

  emulations = fields[2].split()
    if 'elf32ppc' not in emulations or 'elf_x86_64' not in emulations:
        return False

Even my gold doesn't have elf32ppc support.



-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]