This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH 1/2] objcopy: Factor out some of the option parsing code.
- From: Andrew Burgess <andrew dot burgess at embecosm dot com>
- To: binutils at sourceware dot org, rdsandiford at googlemail dot com
- Date: Thu, 26 Feb 2015 00:03:30 +0000
- Subject: Re: [PATCH 1/2] objcopy: Factor out some of the option parsing code.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1424695434 dot git dot andrew dot burgess at embecosm dot com> <175d62402c134c5961a0758844c8262e43e43fc6 dot 1424695434 dot git dot andrew dot burgess at embecosm dot com> <877fv5g0o2 dot fsf at googlemail dot com>
* Richard Sandiford <rdsandiford@googlemail.com> [2015-02-25 21:07:41 +0000]:
> Andrew Burgess <andrew.burgess@embecosm.com> writes:
> > diff --git a/binutils/objcopy.c b/binutils/objcopy.c
> > index 8320793..eb26320 100644
> > --- a/binutils/objcopy.c
> > +++ b/binutils/objcopy.c
> > @@ -3546,6 +3546,79 @@ convert_efi_target (char *efi)
> > }
> > }
> >
> > +/* Allocate and return a pointer to a struct section_add, initialising the
>
> Nit: "initializing". (binutils uses US spelling.)
>
> OK with that change, thanks. I think this should go in independently
> of patch 2, since it's a clean-up in its own right.
Thanks for the review, I pushed with the suggested fix.
Andrew