This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Committed][AArch64] Add support for :tlsdesc: and TLSDESC_ADR_PREL21
- From: Alan Modra <amodra at gmail dot com>
- To: Marcus Shawcroft <marcus dot shawcroft at foss dot arm dot com>
- Cc: binutils at sourceware dot org
- Date: Fri, 27 Feb 2015 12:07:56 +1030
- Subject: Re: [Committed][AArch64] Add support for :tlsdesc: and TLSDESC_ADR_PREL21
- Authentication-results: sourceware.org; auth=none
- References: <54EFA4E3 dot 1050907 at foss dot arm dot com>
On Thu, Feb 26, 2015 at 10:57:39PM +0000, Marcus Shawcroft wrote:
> 2015-02-26 Marcus Shawcroft <marcus.shawcroft@arm.com>
>
> + * elfnn-aarch64.c (IS_AARCH64_TLSDESC_RELOC) BFD_RELOC_AARCH64_TLSDESC_ADR_PREL21 move.
Please fix this overly long entry, which is missing a colon and is
somewhat obscure. The long line attracted my attention, then I
wondered what a "BFD_RELOC... move" was! "Move BFD_RELOC... test"
would have been clearer. Or just
* elfnn-aarch64.c (IS_AARCH64_TLSDESC_RELOC): Reorder R_TYPE tests.
--
Alan Modra
Australia Development Lab, IBM