This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Fixes for a small number of compiler warnings
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>, Ed Schouten <ed at nuxi dot nl>, Binutils <binutils at sourceware dot org>
- Date: Wed, 1 Apr 2015 04:08:15 -0700
- Subject: Re: [PATCH] Fixes for a small number of compiler warnings
- Authentication-results: sourceware.org; auth=none
- References: <CABh_MKmKPHAfVo5Q2BkBnQuGFk-x+5a3j46KtXgF9_af2UHrCg at mail dot gmail dot com> <CABh_MKnE8EBOCuTCofXi2CsWsOVq5xtC+cPqZB-NgotzKFFGLg at mail dot gmail dot com> <20150401003744 dot GN26234 at bubble dot grove dot modra dot org> <alpine dot BSF dot 2 dot 02 dot 1503312120010 dot 87955 at arjuna dot pair dot com> <20150401024707 dot GP26234 at bubble dot grove dot modra dot org> <CAMe9rOrpdXYXG-Lsq3UVCnLxwTk-qFAKZE4Ms5UALquTa9cSNA at mail dot gmail dot com> <20150401032705 dot GQ26234 at bubble dot grove dot modra dot org> <CAMe9rOpi+SxEp8BTacMjuaQ_EcYusd9ks_dbHgNTfUwg0bWCDw at mail dot gmail dot com> <20150401034857 dot GR26234 at bubble dot grove dot modra dot org> <CAMe9rOrYaZpnnRM38k9tqJ_cbNK5j_3wLm+gJeQh_bY4nq2D9A at mail dot gmail dot com> <20150401053346 dot GS26234 at bubble dot grove dot modra dot org>
On Tue, Mar 31, 2015 at 10:33 PM, Alan Modra <amodra@gmail.com> wrote:
> On Tue, Mar 31, 2015 at 08:57:19PM -0700, H.J. Lu wrote:
>> How about something like
>>
>> struct bfd_link_hash_entry
>> SILENCE_UNINIT_WARNING_WITH_SELF_ASSIGN (ehdr_start_save);
>>
>> We define it to self-assign only for those affect GCCs.
>
> Heh, hide it away so it doesn't offend my sense of style? :)
> Well, maybe, but it doesn't seem worth cluttering up the source.
> Nowadays -Werror is turned off by default for releases. Perhaps we
> should turn off -Werror for development if an older gcc is detected?
>
I don't think there is a perfect solution. But I don't want to turn off
-Werror for older GCC.
--
H.J.