This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR gold/17640


On Wed, Apr 1, 2015 at 8:21 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> On 01 Apr 08:15, H.J. Lu wrote:
>> On Wed, Apr 1, 2015 at 7:00 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> > On 30 Mar 11:47, Cary Coutant wrote:
>> >> +2015-03-18  Ilya Tocar  <ilya.tocar@intel.com>
>> >> +
>> >> + PR gold/17640
>> >> + * i386.cc (Target_i386::Scan::local): Don't create GOT entry, when we
>> >> + can convert GOT to GOTOFF.
>> >> + (Target_i386::Scan::global): Ditto.
>> >> + (Target_i386::Relocate::relocate): Convert  mov foo@GOT(%reg), %reg to
>> >> + lea foo@GOTOFF(%reg), %reg if possible.
>> >> + * testsuite/Makefile.am (i386_mov_to_lea): New test.
>> >> + * testsuite/i386_mov_to_lea1.s: New.
>> >> + * testsuite/i386_mov_to_lea2.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea3.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea4.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea5.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea.sh: Ditto.
>> >>
>> >> ChangeLog needs an entry for Sized_target::can_convert_mov_to_lea.
>> >>
>> >> + // If the relocation symbol isn't IFUNC,
>> >> + // and is local, then we will convert
>> >> + // mov foo@GOT(%reg), %reg
>> >> + // to
>> >> + // lea foo@GOTOFF(%reg), %reg
>> >> + // in Relocate::relocate
>> >>
>> >> In comments, please end sentences with periods.
>> >>
>> >> This is OK with those fixes. Thanks!
>> >>
>> >> -cary
>> >
>> > Thanks!
>> >
>> > I've committed version below.
>> >
>>
>> Thanks.
>>
>> Please add yourself to Write After Approval list
>> in binutils/MAINTAINERS.
> In binutils/MAINTAINERS I see (under Write After Approval):
>
> [It's a huge list, folks.  You know who you are.  If you have the
>  *ability* to do binutils checkins, you're in this group.  Just
>  remember to get approval before checking anything in.]
>
> Are you sure I need to add myself there?

Sorry.  My mistake.  No need for it now.

>>
>> Please also fix:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=17641
>>
> I'm working on it.

Thanks.


-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]