This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] PR gold/17640
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 1 Apr 2015 08:25:21 -0700
- Subject: Re: [PATCH] PR gold/17640
- Authentication-results: sourceware.org; auth=none
- References: <CAMe9rOoG6NOVLYxZBJ5KRuS9_47=ptsd=Ft9iA9HfN2Asw0UeQ at mail dot gmail dot com> <20150312143236 dot GA95320 at msticlxl7 dot ims dot intel dot com> <CAMe9rOpn0uGDm1qbwgL-7CiYKjQeSHMHX6WzsnZ6eyfcp2MBAw at mail dot gmail dot com> <20150312145732 dot GB95320 at msticlxl7 dot ims dot intel dot com> <CAHACq4qF26jr8QYR_V55oVewLyHpgD2g7TrxDmgye0_S4pdroQ at mail dot gmail dot com> <20150317214047 dot GA49894 at msticlxl7 dot ims dot intel dot com> <20150323150133 dot GA10265 at msticlxl7 dot ims dot intel dot com> <CAJimCsGb5jO0z6a=eqMXSvjZ8snxf_ihbj4W1rx7+LzhJ6onVw at mail dot gmail dot com> <20150401140045 dot GA32577 at msticlxl7 dot ims dot intel dot com> <CAMe9rOohjZjFCeMiW6xhe3z_x7s3=Syt99Fba4FQoBgfXujBqw at mail dot gmail dot com> <20150401152137 dot GB32577 at msticlxl7 dot ims dot intel dot com>
On Wed, Apr 1, 2015 at 8:21 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> On 01 Apr 08:15, H.J. Lu wrote:
>> On Wed, Apr 1, 2015 at 7:00 AM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
>> > On 30 Mar 11:47, Cary Coutant wrote:
>> >> +2015-03-18 Ilya Tocar <ilya.tocar@intel.com>
>> >> +
>> >> + PR gold/17640
>> >> + * i386.cc (Target_i386::Scan::local): Don't create GOT entry, when we
>> >> + can convert GOT to GOTOFF.
>> >> + (Target_i386::Scan::global): Ditto.
>> >> + (Target_i386::Relocate::relocate): Convert mov foo@GOT(%reg), %reg to
>> >> + lea foo@GOTOFF(%reg), %reg if possible.
>> >> + * testsuite/Makefile.am (i386_mov_to_lea): New test.
>> >> + * testsuite/i386_mov_to_lea1.s: New.
>> >> + * testsuite/i386_mov_to_lea2.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea3.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea4.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea5.s: Ditto.
>> >> + * testsuite/i386_mov_to_lea.sh: Ditto.
>> >>
>> >> ChangeLog needs an entry for Sized_target::can_convert_mov_to_lea.
>> >>
>> >> + // If the relocation symbol isn't IFUNC,
>> >> + // and is local, then we will convert
>> >> + // mov foo@GOT(%reg), %reg
>> >> + // to
>> >> + // lea foo@GOTOFF(%reg), %reg
>> >> + // in Relocate::relocate
>> >>
>> >> In comments, please end sentences with periods.
>> >>
>> >> This is OK with those fixes. Thanks!
>> >>
>> >> -cary
>> >
>> > Thanks!
>> >
>> > I've committed version below.
>> >
>>
>> Thanks.
>>
>> Please add yourself to Write After Approval list
>> in binutils/MAINTAINERS.
> In binutils/MAINTAINERS I see (under Write After Approval):
>
> [It's a huge list, folks. You know who you are. If you have the
> *ability* to do binutils checkins, you're in this group. Just
> remember to get approval before checking anything in.]
>
> Are you sure I need to add myself there?
Sorry. My mistake. No need for it now.
>>
>> Please also fix:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=17641
>>
> I'm working on it.
Thanks.
--
H.J.