This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[gold][aarch64]: Rename '--fix-cortex-a53' to '--fix-cortex-a53-843419'


Hi, Cary, customers suggest gold keep consistency with bfd option
names regarding erratum fixing so as to ease life in Makefile/scripts.
Here is a simple patch for renaming.

Tested - build and use the renamed option.

Is it ok for trunk?

Thanks,
Han

==== Patch starts

diff --git a/gold/aarch64.cc b/gold/aarch64.cc
index 19c3aa0..2745776 100644
--- a/gold/aarch64.cc
+++ b/gold/aarch64.cc
@@ -1280,11 +1280,11 @@ AArch64_relobj<size,
big_endian>::do_count_local_symbols(
 {
   Sized_relobj_file<size, big_endian>::do_count_local_symbols(pool, dynpool);

   // Only erratum-fixing work needs mapping symbols, so skip this
time consuming
   // processing if not fixing erratum.
-  if (!parameters->options().fix_cortex_a53())
+  if (!parameters->options().fix_cortex_a53_843419())
     return;

   const unsigned int loccount = this->local_symbol_count();
   if (loccount == 0)
     return;
@@ -1588,11 +1588,11 @@ AArch64_relobj<size,
big_endian>::scan_sections_for_stubs(
   // Do relocation stubs scanning.
   const unsigned char* p = pshdrs + shdr_size;
   for (unsigned int i = 1; i < shnum; ++i, p += shdr_size)
     {
       const elfcpp::Shdr<size, big_endian> shdr(p);
-      if (parameters->options().fix_cortex_a53())
+      if (parameters->options().fix_cortex_a53_843419())
  scan_erratum_843419(i, shdr, out_sections[i], symtab, target);
       if (this->section_needs_reloc_stub_scanning(shdr, out_sections, symtab,
   pshdrs))
  {
   unsigned int index = this->adjust_shndx(shdr.get_sh_info());
diff --git a/gold/options.h b/gold/options.h
index bb3bee6..67eb1b2 100644
--- a/gold/options.h
+++ b/gold/options.h
@@ -800,13 +800,14 @@ class General_options

   DEFINE_bool(fix_cortex_a8, options::TWO_DASHES, '\0', false,
       N_("(ARM only) Fix binaries for Cortex-A8 erratum."),
       N_("(ARM only) Do not fix binaries for Cortex-A8 erratum."));

-  DEFINE_bool(fix_cortex_a53, options::TWO_DASHES, '\0', false,
-      N_("(AArch64 only) Scan and fix binaries for Cortex-A53 errata."),
-      N_("(AArch64 only) Do not scan for Cortex-A53 errata."));
+  DEFINE_bool(fix_cortex_a53_843419, options::TWO_DASHES, '\0', false,
+      N_("(AArch64 only) Scan binaries for Cortex-A53 errata 843419."),
+      N_("(AArch64 only) Do not scan binaries for Cortex-A53 "
+ "errata 843419."));

   DEFINE_bool(fix_arm1176, options::TWO_DASHES, '\0', true,
       N_("(ARM only) Fix binaries for ARM1176 erratum."),
       N_("(ARM only) Do not fix binaries for ARM1176 erratum."));



Thanks,
Han


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]