This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [AArch64][2/2] BFD Support BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15
- From: Jiong Wang <jiong dot wang at arm dot com>
- To: Nicholas Clifton <nickc at redhat dot com>
- Cc: "binutils\ at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 02 Jun 2015 14:06:02 +0100
- Subject: Re: [AArch64][2/2] BFD Support BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15
- Authentication-results: sourceware.org; auth=none
- References: <n99fv6rwmcb dot fsf at arm dot com> <55687D47 dot 1010200 at redhat dot com>
Nicholas Clifton writes:
> Hi Jiong,
>
>> 2015-05-19 Jiong Wang <jiong.wang@arm.com>
>>
>> bfd/
>> * elfnn-aarch64.c (aarch64_reloc_got_type): Support
>> BFD_RELOC_AARCH64_LD64_GOTPAGE_LO15.
>> (elfNN_aarch64_final_link_relocate): Ditto.
>> (elfNN_aarch64_gc_swap_hook): Ditto.
>> (elfNN_aarch64_check_relocs): Ditto.
>> * elfxx-aarch64.c (_bfd_aarch64_elf_put_addend): Ditto.
>>
>> ld/testsuite/
>> * ld-aarch64/emit-relocs-313.s: New test file.
>> * ld-aarch64/emit-relocs-313.d: Ditto.
>> * ld-aarch64/aarch64-elf.exp: Run new test.
>
> Approved - please apply.
>
> Cheers
> Nick
Nick,
Thanks for the review. Committed.
During the commit, I applied the wrong patch, sorry. I checked in
the following obivious patch to upload the correct version of patch.
--
Regards,
Jiong
commit afa403d8d467466edfd77baea0bba7ae45a4447f
Author: Jiong Wang <jiong.wang@arm.com>
Date: Tue Jun 2 13:59:17 2015 +0100
[AArch64] Fix typo in testcase
ld/testsuite/
* ld-aarch64/emit-relocs-313.s: Use gotpage_lo15.
diff --git a/ld/testsuite/ChangeLog b/ld/testsuite/ChangeLog
index a68a217..fe62990 100644
--- a/ld/testsuite/ChangeLog
+++ b/ld/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-06-02 Jiong Wang <jiong.wang@arm.com>
+
+ * ld-aarch64/emit-relocs-313.s: Use gotpage_lo15.
+
2015-06-01 Jiong Wang <jiong.wang@arm.com>
* ld-aarch64/emit-relocs-28.s: New test file.
diff --git a/ld/testsuite/ld-aarch64/emit-relocs-313.s b/ld/testsuite/ld-aarch64/emit-relocs-313.s
index b13a0e5..e3858e3 100644
--- a/ld/testsuite/ld-aarch64/emit-relocs-313.s
+++ b/ld/testsuite/ld-aarch64/emit-relocs-313.s
@@ -1,5 +1,5 @@
.text
adrp x2, _GLOBAL_OFFSET_TABLE_
- ldr x0, [x2, #:gotpage_lo14:globala]
- ldr x0, [x2, #:gotpage_lo14:globalb]
- ldr x0, [x2, #:gotpage_lo14:globalc]
+ ldr x0, [x2, #:gotpage_lo15:globala]
+ ldr x0, [x2, #:gotpage_lo15:globalb]
+ ldr x0, [x2, #:gotpage_lo15:globalc]