This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH][AArch64] Fix extern protected data handling
- From: Szabolcs Nagy <szabolcs dot nagy at arm dot com>
- To: Binutils <binutils at sourceware dot org>
- Cc: Marcus Shawcroft <marcus dot shawcroft at arm dot com>
- Date: Wed, 22 Jul 2015 17:23:15 +0100
- Subject: [PATCH][AArch64] Fix extern protected data handling
- Authentication-results: sourceware.org; auth=none
Emit *GLOB_DAT instead of *RELATIVE relocs for protected data
in shared objects.
This is needed for the fix of glibc bug 17711:
https://sourceware.org/bugzilla/show_bug.cgi?id=17711
bfd/ChangeLog:
2015-07-22 Szabolcs Nagy <szabolcs.nagy@arm.com>
PR ld/18705
* elfnn-aarch64.c (elf_backend_extern_protected_data): Define.
ld/testsuite/ChangeLog:
2015-07-22 Szabolcs Nagy <szabolcs.nagy@arm.com>
PR ld/18705
ld-aarch64/protected-data.d: New.
ld-aarch64/protected-data.s: New.
ld-aarch64/aarch64-elf.exp: Add new test.
diff --git a/bfd/elfnn-aarch64.c b/bfd/elfnn-aarch64.c
index b13f5db..9749830 100644
--- a/bfd/elfnn-aarch64.c
+++ b/bfd/elfnn-aarch64.c
@@ -8625,6 +8625,7 @@ const struct elf_size_info elfNN_aarch64_size_info =
#define elf_backend_rela_normal 1
#define elf_backend_got_header_size (GOT_ENTRY_SIZE * 3)
#define elf_backend_default_execstack 0
+#define elf_backend_extern_protected_data 1
#undef elf_backend_obj_attrs_section
#define elf_backend_obj_attrs_section ".ARM.attributes"
diff --git a/ld/testsuite/ld-aarch64/aarch64-elf.exp b/ld/testsuite/ld-aarch64/aarch64-elf.exp
index ac21d14..ab58210 100644
--- a/ld/testsuite/ld-aarch64/aarch64-elf.exp
+++ b/ld/testsuite/ld-aarch64/aarch64-elf.exp
@@ -156,6 +156,7 @@ run_dump_test "gc-relocs-257"
run_dump_test "pr17415"
run_dump_test "tprel_g2_overflow"
run_dump_test "tprel_add_lo12_overflow"
+run_dump_test "protected-data"
# ifunc tests
run_dump_test "ifunc-1"
diff --git a/ld/testsuite/ld-aarch64/protected-data.d b/ld/testsuite/ld-aarch64/protected-data.d
new file mode 100644
index 0000000..df106dc
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/protected-data.d
@@ -0,0 +1,4 @@
+#ld: -shared
+#readelf: -r -W
+#...
+.* R_AARCH64_GLOB_DAT .* var.*
diff --git a/ld/testsuite/ld-aarch64/protected-data.s b/ld/testsuite/ld-aarch64/protected-data.s
new file mode 100644
index 0000000..4878f05
--- /dev/null
+++ b/ld/testsuite/ld-aarch64/protected-data.s
@@ -0,0 +1,18 @@
+ .data
+ .protected var
+ .global var
+ .align 2
+ .type var, %object
+ .size var, 4
+var:
+ .word 1
+
+ .text
+ .align 2
+ .global getaddr
+ .type getaddr, %function
+getaddr:
+ adrp x0, :got:var
+ ldr x0, [x0, #:got_lo12:var]
+ ret
+ .size getaddr, .-getaddr