This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [AArch64][5/6] GAS support TLSLD load/store relocation types
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Jiong Wang <jiong dot wang at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Wed, 19 Aug 2015 16:21:57 +0100
- Subject: Re: [AArch64][5/6] GAS support TLSLD load/store relocation types
- Authentication-results: sourceware.org; auth=none
- References: <55D46D3C dot 6070406 at arm dot com> <55D46E1D dot 4000104 at arm dot com> <55D46E7A dot 3010004 at arm dot com> <55D46EFE dot 9060508 at arm dot com> <55D46FAD dot 9090601 at arm dot com> <55D47780 dot 5010005 at arm dot com>
On 19 August 2015 at 13:33, Jiong Wang <jiong.wang@arm.com> wrote:
> All these relocation types are for LDST instructions, they share the
> same gas internal logic, so put them together.
>
> 2015-08-19 Jiong Wang <jiong.wang@arm.com>
>
> bfd/
> * reloc.c: New entries, including
> BFD_RELOC_AARCH64_TLSLD_LDST16_DTPREL_LO12,
> BFD_RELOC_AARCH64_TLSLD_LDST16_DTPREL_LO12_NC,
> BFD_RELOC_AARCH64_TLSLD_LDST32_DTPREL_LO12,
> BFD_RELOC_AARCH64_TLSLD_LDST32_DTPREL_LO12_NC,
> BFD_RELOC_AARCH64_TLSLD_LDST64_DTPREL_LO12,
> BFD_RELOC_AARCH64_TLSLD_LDST64_DTPREL_LO12_NC.
> BFD_RELOC_AARCH64_TLSLD_LDST8_DTPREL_LO12,
> BFD_RELOC_AARCH64_TLSLD_LDST8_DTPREL_LO12_NC.
I think the reloc name should be comma separated between ().
> gas/
> * config/tc-aarch64.c (reloc_table): New relocation modifiers.
Please list the relocation modifiers added.
> (ldst_lo12_determine_real_reloc_type): Support new LDST reloc types.
> (parse_operands): Likewise.
> (md_apply_fix): Support new relocation types.
Likewise.
> (aarch64_force_relocation): Likewise.
> (process_movw_reloc_info): Likewise.
>
> gas/testsuite/
> * gas/aarch64/reloc-dtprel-lo12-ldst8.s: New testcase.
> * gas/aarch64/reloc-dtprel-lo12-ldst8-nc.s: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst16.s: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst16-nc.s: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst32.s: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst32-nc.s: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst64.s: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst64-nc.s: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst8.d: New expectation file.
> * gas/aarch64/reloc-dtprel-lo12-ldst8-nc.d: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst16.d: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst16-nc.d: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst32.d: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst32-nc.d: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst64.d: Likewise.
> * gas/aarch64/reloc-dtprel-lo12-ldst64-nc.d: Likewise.
>
OK, thanks /Marcus