This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [BFD][PATCH]Fix a typo in the comment for BFD_RELOC_AARCH64_LD64_GOT_LO12_NC
- From: Renlin Li <renlin dot li at arm dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Thu, 20 Aug 2015 15:56:01 +0100
- Subject: Re: [BFD][PATCH]Fix a typo in the comment for BFD_RELOC_AARCH64_LD64_GOT_LO12_NC
- Authentication-results: sourceware.org; auth=none
- References: <55D4A587 dot 3050605 at arm dot com> <mvmzj1nb74e dot fsf at hawking dot suse dot de>
Hi Andreas,
On 19/08/15 17:00, Andreas Schwab wrote:
Renlin Li<renlin.li@arm.com> writes:
This is a simple patch to fix a typo in the comment found in reloc.c. It
should be ILP64, instead of LP64.
Did you mean ILP32?
I did mean ILP64, but I was wrong. Thank you for pointing it out. LP64
here is correct.
It's the "ILP64" in the documentation for
BFD_RELOC_AARCH64_LD64_GOTOFF_LO15 need to be corrected. Please check
the new attached patch.
Thank you!
Renlin Li
bfd/ChangeLog:
2015-08-20 Renlin Li <renlin.li@arm.com>
* reloc.c (BFD_RELOC_AARCH64_LD64_GOTOFF_LO15): Use LP64 instead of
ILP64.
* bfd-in2.h: Regenerate.
Andreas.
commit ba0f4b2c823eae23e49d028cb4f1f872246f8853
Author: Renlin Li <renlin.li@arm.com>
Date: Thu Aug 20 09:38:28 2015 +0100
fix typo
diff --git a/bfd/bfd-in2.h b/bfd/bfd-in2.h
index 3299055..a8aebd2 100644
--- a/bfd/bfd-in2.h
+++ b/bfd/bfd-in2.h
@@ -5753,7 +5753,7 @@ BFD_RELOC_AARCH64_ADR_GOTPAGE. Valid in ILP32 ABI only. */
BFD_RELOC_AARCH64_LD32_GOT_LO12_NC,
/* Unsigned 15 bit byte offset for 64 bit load/store from the page of
-the GOT entry for this symbol. Valid in ILP64 ABI only. */
+the GOT entry for this symbol. Valid in LP64 ABI only. */
BFD_RELOC_AARCH64_LD64_GOTOFF_LO15,
/* Scaled 14 bit byte offset to the page base of the global offset table. */
diff --git a/bfd/reloc.c b/bfd/reloc.c
index 83b7cd2..b845f50 100644
--- a/bfd/reloc.c
+++ b/bfd/reloc.c
@@ -6793,7 +6793,7 @@ ENUM
BFD_RELOC_AARCH64_LD64_GOTOFF_LO15
ENUMDOC
Unsigned 15 bit byte offset for 64 bit load/store from the page of
- the GOT entry for this symbol. Valid in ILP64 ABI only.
+ the GOT entry for this symbol. Valid in LP64 ABI only.
ENUM
BFD_RELOC_AARCH64_LD32_GOTPAGE_LO14
ENUMDOC