This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Support PIE on Solaris 12


"H.J. Lu" <hjl.tools@gmail.com> writes:

> On Wed, Sep 2, 2015 at 4:38 AM, Rainer Orth <ro@cebitec.uni-bielefeld.de> wrote:
>> "H.J. Lu" <hjl.tools@gmail.com> writes:
>>
>>>> 2015-08-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>
>>>>
>>>>         ld:
>>>>         * emulparams/solaris2.sh (GENERATE_PIE_SCRIPT): Set to yes.
>>>>
>>>>         * emultempl/elf32.em (ld_${EMULATION_NAME}_emulation): Allow
>>>>         overriding gld${EMULATION_NAME}_handle_option.
>>>>         * emultempl/solaris2.em: Include ldlex.h.
>>>>         (gld${EMULATION_NAME}_handle_option): Declare.
>>>>         (elf_solaris2_handle_option): New function.
>>>>         (LDEMUL_HANDLE_OPTION): Uset it.
>>>>
>>>>         include/elf:
>>>>         * common.h (DF_1_STUB, DF_1_PIE): Define.
>>>>
>>>>         binutils:
>>>>         * readelf.c (process_dynamic_section): Handle DF_1_STUB, DF_1_PIE.
>>>
>>> Should we set DF_1_PIE for Linux?
>>
>> That's nothing I can decide ;-)  It's mostly informational on Solaris,
>> so I guess there's no harm doing it on Linux, too.
>>
>>         Rainer
>
> We should.

That certainly massively simplifies that patch ;-)  The following
(resending only the ld part for now) has been very lightly tested by
checking that DF_1_PIE is set in a Solaris 12 gcc build with gas/gld
configured with --enable-default-pie.

	Rainer


2015-09-03  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	ld:
	* emulparams/solaris2.sh (GENERATE_PIE_SCRIPT): Set to yes.

	* emultempl/elf32.em: Include ldlex.h.
	(gld${EMULATION_NAME}_handle_option) [GENERATE_PIE_SCRIPT]
	<OPTION_PIE>: Set DF_1_PIE.

diff --git a/ld/emulparams/solaris2.sh b/ld/emulparams/solaris2.sh
--- a/ld/emulparams/solaris2.sh
+++ b/ld/emulparams/solaris2.sh
@@ -8,3 +8,5 @@
 # File, p.63.
 TEXT_START_SYMBOLS='_START_ = .;'
 OTHER_END_SYMBOLS='_END_ = .;'
+# Beginning with Solaris 12, there's PIE support.
+GENERATE_PIE_SCRIPT=yes
diff --git a/ld/emultempl/elf32.em b/ld/emultempl/elf32.em
--- a/ld/emultempl/elf32.em
+++ b/ld/emultempl/elf32.em
@@ -49,6 +49,7 @@ fragment <<EOF
 #include "ldmain.h"
 #include "ldmisc.h"
 #include "ldexp.h"
+#include "ldlex.h"
 #include "ldlang.h"
 #include "ldfile.h"
 #include "ldemul.h"
@@ -2285,6 +2286,13 @@ fragment <<EOF
 
 EOF
 fi
+if test x"$GENERATE_PIE_SCRIPT" = xyes; then
+fragment <<EOF
+    case OPTION_PIE:
+      link_info.flags_1 |= (bfd_vma) DF_1_PIE;
+      break;
+EOF
+fi
 fragment <<EOF
     case 'z':
       if (strcmp (optarg, "defs") == 0)
-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]