Re: [PATCH ARC 3/8] GAS: new ARC port

[Nick Clifton <nickc at redhat dot com>]

Hi Claudiu,

> To our
> knowledge, there is no one doing development or using the old ARC
> CPUs.

Are you sure ?

But OK, I am willing to accept this assertion.  Given that the machine 
number is different then, I no longer have any concerns about the e_flag 
bits.  But I do think that you ought to extend the warning message for 
when you detect old/unknown binaries in arc_elf_object_p().  Currently I 
think that you have:

  else
    {
      /* This is an old ARC, throw a warning. Probably the best is to
       * return FALSE.  */
      (*_bfd_error_handler)
	  (_("Warning: unset or old architecture flags. \n"
	     "	       Use default machine.\n"));
    }

Please could you extend this to something like:

  else
    {
      if (e_machine == EM_ARC)
        {
          (*_bfd_error_handler)
            (_("Error: The ARC4 architecture is no longer supported.\n");
           return FALSE;
        }
      else
        (*_bfd_error_handler)
	  (_("Warning: unset or old architecture flags.\n"
	     "	       Selecting the default ARC architecture.\n"));
    }

Cheers
  Nick