This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[gold][PATCH] PR gold/19119: Gold accepts bogus target emulation
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Cc: Cary Coutant <ccoutant at gmail dot com>
- Date: Wed, 14 Oct 2015 09:05:35 -0700
- Subject: [gold][PATCH] PR gold/19119: Gold accepts bogus target emulation
- Authentication-results: sourceware.org; auth=none
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
Gold shouldn't ignore "-m emulation" command line option, which may
lead to incorrect output.
PR gold/19119
* options.h (General_options): Remove "obsolete" from -m.
* parameters.cc (set_parameters_target): Check if input target
is compatible with output emulation set by "-m emulation".
---
gold/options.h | 2 +-
gold/parameters.cc | 10 ++++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/gold/options.h b/gold/options.h
index 641efee..4d65225 100644
--- a/gold/options.h
+++ b/gold/options.h
@@ -934,7 +934,7 @@ class General_options
N_("OFFSET"));
DEFINE_string(m, options::EXACTLY_ONE_DASH, 'm', "",
- N_("Set GNU linker emulation; obsolete"), N_("EMULATION"));
+ N_("Set GNU linker emulation"), N_("EMULATION"));
DEFINE_bool(mmap_output_file, options::TWO_DASHES, '\0', true,
N_("Map the output file for writing (default)."),
diff --git a/gold/parameters.cc b/gold/parameters.cc
index 5ed1912..15df42a 100644
--- a/gold/parameters.cc
+++ b/gold/parameters.cc
@@ -297,6 +297,16 @@ set_parameters_options(const General_options* options)
void
set_parameters_target(Target* target)
{
+ if (parameters->options_valid() && parameters->options().user_set_m())
+ {
+ const char* emulation = parameters->options().m();
+ Target* output = select_target_by_emulation(emulation);
+ if (!output)
+ gold_error(_("unrecognised output emulation: %s"), emulation);
+ else if (output != target)
+ gold_error(_("input file is incompatible with %s output emulation"),
+ emulation);
+ }
static_parameters.set_target(target);
}
--
2.4.3