RE: [PATCH] arc/gas: Accept, but ignore, dummy arguments.

[Claudiu Zissulescu <Claudiu dot Zissulescu at synopsys dot com>]

Indeed, how could I miss that! Locally, we have it correctly done. From our side it is ok.

Best,
Claudiu

> -----Original Message-----
> From: Andrew Burgess [mailto:andrew.burgess@embecosm.com]
> Sent: Wednesday, December 09, 2015 8:21 PM
> To: binutils@sourceware.org
> Cc: Claudiu.Zissulescu@synopsys.com; Cupertino.Miranda@synopsys.com;
> Andrew Burgess
> Subject: [PATCH] arc/gas: Accept, but ignore, dummy arguments.
> 
> There's a set of legacy command line arguments that the arc assembler still
> accepts, however, these arguments not longer have any effect on the
> assembler.
> 
> Currently we return false from md_parse_option for all of these arguments,
> with the result that the assembler terminates with an error message.
> 
> We should return true indicating that the argument has been accepted, even
> though we ignore it.
> 
> gas/ChangeLog:
> 
> 	* config/tc-arc.c (md_parse_option): Return 1 in order to accept
> 	dummy arguments.
> ---
>  gas/ChangeLog       | 5 +++++
>  gas/config/tc-arc.c | 3 ++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gas/ChangeLog b/gas/ChangeLog index 147925e..1b574bc 100644
> --- a/gas/ChangeLog
> +++ b/gas/ChangeLog
> @@ -1,3 +1,8 @@
> +2015-12-09  Andrew Burgess  <andrew.burgess@embecosm.com>
> +
> +	* config/tc-arc.c (md_parse_option): Return 1 in order to accept
> +	dummy arguments.
> +
>  2015-12-09  Jose E. Marchesi  <jose.marchesi@oracle.com>
> 
>  	* config/tc-sparc.c (sparc_ip): Support %dN and %qN notation for diff
> --git a/gas/config/tc-arc.c b/gas/config/tc-arc.c index cbf2180..0686945
> 100644
> --- a/gas/config/tc-arc.c
> +++ b/gas/config/tc-arc.c
> @@ -1764,7 +1764,8 @@ md_parse_option (int c, char *arg
> ATTRIBUTE_UNUSED)
>      case OPTION_SWAPE:
>      case OPTION_RTSC:
>      case OPTION_FPUDA:
> -      /* Dummy options.  */
> +      /* Dummy options are accepted but have no effect.  */
> +      break;
> 
>      default:
>        return 0;
> --
> 2.5.1