This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] gold: Implement --long-plt flag.
- From: Cary Coutant <ccoutant at gmail dot com>
- To: Peter Collingbourne <pcc at google dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 16 Dec 2015 16:42:02 -0800
- Subject: Re: [PATCH] gold: Implement --long-plt flag.
- Authentication-results: sourceware.org; auth=none
- References: <1448063109-18860-1-git-send-email-pcc at google dot com>
> template<bool big_endian>
> void
> -Output_data_plt_arm_standard<big_endian>::do_fill_plt_entry(
> +Output_data_plt_arm_short<big_endian>::do_fill_plt_entry(
> unsigned char* pov,
> Arm_address got_address,
> Arm_address plt_address,
Please fix this routine to issue an error message, suggesting the use
of --long-plt, if the offset overflows the standard PLT.
> + DEFINE_bool(long_plt, options::TWO_DASHES, '\0', false,
> + N_("(ARM only) Generate long PLT entries."),
> + N_("(ARM only) Do not generate long PLT entries."));
Help strings should not end with periods. (Yeah, there are some already there.)
This is OK with those changes.
-cary