This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [Patch ARM ] Fix build attributes for armv8-a in case of assembler files that contain no directives
- From: Tristan Gingold <gingold at adacore dot com>
- To: "Richard Earnshaw (lists)" <Richard dot Earnshaw at arm dot com>
- Cc: Ramana Radhakrishnan <ramana dot radhakrishnan at foss dot arm dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Thu, 17 Dec 2015 18:05:05 +0100
- Subject: Re: [Patch ARM ] Fix build attributes for armv8-a in case of assembler files that contain no directives
- Authentication-results: sourceware.org; auth=none
- References: <56729D87 dot 7030500 at foss dot arm dot com> <56729F5C dot 6060802 at arm dot com> <5672BD3A dot 3090109 at arm dot com> <F8DA562E-B5DE-4D05-AC6E-F8E029B09DBC at adacore dot com> <5672D586 dot 8090408 at arm dot com> <5672E7D3 dot 4020104 at arm dot com>
> On 17 Dec 2015, at 17:50, Richard Earnshaw (lists) <Richard.Earnshaw@arm.com> wrote:
>
> On 17/12/15 15:32, Richard Earnshaw (lists) wrote:
>> On 17/12/15 15:15, Tristan Gingold wrote:
>>>
>>>> On 17 Dec 2015, at 14:48, Richard Earnshaw (lists) <Richard.Earnshaw@arm.com> wrote:
>>>>
>>>> On 17/12/15 11:41, Richard Earnshaw (lists) wrote:
>>>>> On 17/12/15 11:33, Ramana Radhakrishnan wrote:
>>>>>> Hi,
>>>>>>
>>>>>> There is currently a problem in the way in which we produce
>>>>>> build attributes for simple assembler files that have armv8-a
>>>>>> instructions.
>>>>>>
>>>>>> In these case we need to generate TAG_ISA_THUMB_Use to be Thumb-2
>>>>>> and set the architecture profile to be 'A' rather than not
>>>>>> setting architecture profile to be 'A' and setting TAG_ISA_THUMB_Use
>>>>>> to be Thumb-1.
>>>>>>
>>>>>> This is a pre-requisite for any v8-m patches that have been posted.
>>>>>> arm-none-eabi gas testsuite run. no regressions.
>>>>>>
>>>>>> Applied to trunk.
>>>>>>
>>>>>> regards
>>>>>> Ramana
>>>>>>
>>>>>>
>>>>>> 2015-12-17 Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>>>>>>
>>>>>> * gas/config/tc-arm.c (aeabi_set_public_attributes): Adjust
>>>>>> TAG_ARCH_profile for armv8-a.
>>>>>> * gas/testsuite/gas/arm/armv8a-automatic-hlt.d: New test.
>>>>>> * gas/testsuite/gas/arm/armv8a-automatic-hlt.s: New test.
>>>>>> * gas/testsuite/gas/arm/armv8a-automatic-lda.d: New test.
>>>>>> * gas/testsuite/gas/arm/armv8a-automatic-lda.s: New test.
>>>>>>
>>>>>
>>>>> I think it's worth getting this in before the v8-m changes, so OK.
>>>>>
>>>>
>>>> I'd also like to see this on the release branch since it fixes a bug in
>>>> the tools.
>>>>
>>>> Tristan?
>>>
>>> Yes (bis).
>>>
>>
>> Done.
>
> Apologies, it appears Ramana forgot to commit the ChangeLog entry in the
> original commit. I've fixed that up on both the master and release
> branches as best I can.
Thanks.