This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC PATCH 03/11] MIPS/BFD: Suppress attribute checks for null input
- From: "Maciej W. Rozycki" <macro at imgtec dot com>
- To: Richard Sandiford <rdsandiford at googlemail dot com>
- Cc: <binutils at sourceware dot org>, Matthew Fortune <Matthew dot Fortune at imgtec dot com>, Daniel Sanders <Daniel dot Sanders at imgtec dot com>
- Date: Tue, 5 Jan 2016 18:30:24 +0000
- Subject: Re: [RFC PATCH 03/11] MIPS/BFD: Suppress attribute checks for null input
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 00 dot 1511200755190 dot 6915 at tp dot orcam dot me dot uk> <alpine dot DEB dot 2 dot 00 dot 1511200815540 dot 6915 at tp dot orcam dot me dot uk> <87twnjl9kd dot fsf at googlemail dot com>
On Tue, 15 Dec 2015, Richard Sandiford wrote:
> > - /* Check to see if the input BFD actually contains any sections.
> > - If not, its flags may not have been initialised either, but it cannot
> > - actually cause any incompatibility. */
> > + /* Check to see if the input BFD actually contains any sections. If not,
> > + its flags or attributes may not have been initialised either, but it
> > + cannot actually cause any incompatibility. */
>
> ...the comment seems a little confusing, since it implies that attributes
> might have been initialised. How about:
>
> If not, it has no attributes, and its flags may not have been
> initialized either, but it cannot actually cause any incompatibility.
>
> (US spelling: initialized)
Indeed, it slipped through somehow.
> OK independently of the rest with that change, thanks.
I've committed it now with a minor update: "If not, then...", mainly for
aesthetic reasons. Thanks for your review.
Maciej