This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC PATCH 03/11] MIPS/BFD: Suppress attribute checks for null input


On Tue, 15 Dec 2015, Richard Sandiford wrote:

> > -  /* Check to see if the input BFD actually contains any sections.
> > -     If not, its flags may not have been initialised either, but it cannot
> > -     actually cause any incompatibility.  */
> > +  /* Check to see if the input BFD actually contains any sections.  If not,
> > +     its flags or attributes may not have been initialised either, but it
> > +     cannot actually cause any incompatibility.  */
> 
> ...the comment seems a little confusing, since it implies that attributes
> might have been initialised.  How about:
> 
>    If not, it has no attributes, and its flags may not have been
>    initialized either, but it cannot actually cause any incompatibility.
> 
> (US spelling: initialized)

 Indeed, it slipped through somehow.

> OK independently of the rest with that change, thanks.

 I've committed it now with a minor update: "If not, then...", mainly for 
aesthetic reasons.  Thanks for your review.

  Maciej


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]