This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PUSHED] [PATCH] bfd/arc: Add R_ prefix to all relocation names


* Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com> [2016-01-06 13:54:00 +0000]:

> This is ok from our side.
> 
> //Claudiu
> 
> > -----Original Message-----
> > From: Andrew Burgess [mailto:andrew.burgess@embecosm.com]
> > Sent: Tuesday, January 05, 2016 3:57 PM
> > To: binutils@sourceware.org
> > Cc: Claudiu.Zissulescu@synopsys.com; Cupertino.Miranda@synopsys.com;
> > Andrew Burgess
> > Subject: [PATCH] bfd/arc: Add R_ prefix to all relocation names
> > 
> > The convention within for relocation names is that they start with the string
> > "R_", however, this is not so for ARC for the display names of relocations,
> > however, internally, the names for the relocations types do have the 'R_'
> > prefix.  I suspect that the missing 'R_' on the output strings was an oversight,
> > as I can't see any comment to the contrary.
> > 
> > To bring ARC into line with other targets, this commit adds the 'R_'
> > prefix to the output strings used for relocation names, and updates all of the
> > assembler tests where this was exposed.
> > 
> > bfd/ChangeLog:
> > 
> > 	* elf32-arc.c (reloc_type_to_name): Change ARC_RELOC_HOWTO to
> > 	place 'R_' before the reloc name returned.
> > 	(elf_arc_howto_table): Change ARC_RELOC_HOWTO to place 'R_'
> > before
> > 	the relocation string.
> > 

I've pushed this as an obvious fix now that Claudiu has given
approval.

Thanks,
Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]