This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Nios II/GAS: Fix build error in `output_movia'


On 01/07/2016 08:32 AM, Maciej W. Rozycki wrote:

Index: binutils/gas/config/tc-nios2.c
===================================================================
--- binutils.orig/gas/config/tc-nios2.c	2015-09-11 18:32:12.000000000 +0100
+++ binutils/gas/config/tc-nios2.c	2015-11-20 11:08:15.636397734 +0000
@@ -3471,7 +3471,7 @@ output_movia (nios2_insn_infoS *insn)
       and puts it in the current frag.  */
    char *f = frag_more (8);
    nios2_insn_relocS *reloc = insn->insn_reloc;
-  unsigned long reg, code;
+  unsigned long reg, code = 0;
    const struct nios2_opcode *op = insn->insn_nios2_opcode;

    /* If the reloc is NULL, there was an error assembling the movia.  */


This is fine for trunk -- I think it qualifies as an obvious fix, even. I'm not sure what the rules are for commits to release branches but I have no objection to applying the patch there as well if it's needed to prevent some breakage.

-Sandra


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]