This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Cary Coutant <ccoutant at gmail dot com>
- Cc: Vladimir Radosavljevic <Vladimir dot Radosavljevic at imgtec dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>, Petar Jovanovic <Petar dot Jovanovic at imgtec dot com>
- Date: Tue, 12 Jan 2016 12:10:10 -0800
- Subject: Re: [PATCH v2 2/4] gold: Correctly get and put r_info for Mips64el.
- Authentication-results: sourceware.org; auth=none
- References: <3060420525346945A0ADBD567348A91723737257 at BADAG02 dot ba dot imgtec dot org> <CAJimCsFogsVm1t6zjzsP_Es4vjnXHMzjG3RnGZ_zy7VtDLk+qQ at mail dot gmail dot com> <CAMe9rOo1APZo115ObjArBkm_whctwDWFBXVR218+o9XCwRmRsw at mail dot gmail dot com> <CAJimCsEhL_B0xa1tMPSMN3skK26LX=tCmBWe_zUHnuZHu0EqjQ at mail dot gmail dot com>
On Tue, Jan 12, 2016 at 11:30 AM, Cary Coutant <ccoutant@gmail.com> wrote:
>> It failed to build with GCC 4.2:
>>
>> /net/gnu-6/export/linux/src/binutils/binutils/gold/../elfcpp/elfcpp_internal.h:187:
>> error: using âtypenameâ outside of template
>> /net/gnu-6/export/linux/src/binutils/binutils/gold/../elfcpp/elfcpp_internal.h:197:
>> error: using âtypenameâ outside of template
>> /net/gnu-6/export/linux/src/binutils/binutils/gold/../elfcpp/elfcpp_internal.h:203:
>> error: using âtypenameâ outside of template
>>
>> This patch fixes the build.
>
> Thanks! I've pushed your patch.
>
> 2016-01-12 H.J. Lu <hongjiu.lu@intel.com>
>
> * elfcpp_internal.h (Mips64_rel_data, Mips64_rela_data): Remove
> 'typename'.
>
I checked in this one to remove another typename.
--
H.J.
---
From f9498162b9aae9233a6d37c102bf744b77961226 Mon Sep 17 00:00:00 2001
From: "H.J. Lu" <hjl.tools@gmail.com>
Date: Tue, 12 Jan 2016 12:08:06 -0800
Subject: [PATCH] Remove typename from Mips64_rela_data
---
elfcpp/elfcpp_internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/elfcpp/elfcpp_internal.h b/elfcpp/elfcpp_internal.h
index a5d647f..2aaeeba 100644
--- a/elfcpp/elfcpp_internal.h
+++ b/elfcpp/elfcpp_internal.h
@@ -200,7 +200,7 @@ struct Mips64_rela_data
unsigned char r_type3;
unsigned char r_type2;
unsigned char r_type;
- typename Elf_types<64>::Elf_Swxword r_addend;
+ Elf_types<64>::Elf_Swxword r_addend;
};
// An entry in the ELF SHT_DYNAMIC section aka PT_DYNAMIC segment.
--