This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Commit: xfail rgn-at11 test for MIPS


Hi Alan,

Although for the MIPS case the test could also be modified to use 16-byte
alignment for the sections and then the test would pass. Leaving it as an
XFAIL then might prompt some future maintainer to make this change...

Particularly since mipstx39-elf XPASSes the test.

Good point. So I have re-enabled the rgn-at11 test for MIPS targets with an adjusted source file that uses 16 byte section alignment.

Cheers
  Nick

ld/ChangeLog

2016-01-18  Nick Clifton  <nickc@redhat.com>

	* testsuite/ld-scripts/rgn-at11.s: New file - based on rgn-at10.s
	but with 16 byte section alignment.
	* testsuite/ld-scripts/rgn-at11.d: Use new source file.  Reenable
	test for MIPS targets.
diff --git a/ld/testsuite/ld-scripts/rgn-at11.d b/ld/testsuite/ld-scripts/rgn-at11.d
index e37cbd7..297ae46 100644
--- a/ld/testsuite/ld-scripts/rgn-at11.d
+++ b/ld/testsuite/ld-scripts/rgn-at11.d
@@ -1,14 +1,12 @@
-#source: rgn-at10.s
+#source: rgn-at11.s
 #ld: -T rgn-at11.t
 #objdump: -h --wide
-#xfail: rx-*-* mips*-*-*
+#xfail: rx-*-*
# Test that lma is not adjusted in case the section start vma is aligned and
 # lma_region != region if not requested by script.
# Fails for RX because it ignores the LMA (for compatibility with Renesas tools) -# Fails for MIPS targets because the assembler pads all sections to a 16 byte
-# boundary.

 #...
 .* 0+10000 +0+20000 .*
-.* 0+10100 +0+20004 .*
-.* 0+10100 +0+20004 .*
+.* 0+10100 +0+20010 .*
+.* 0+10100 +0+20010 .*
diff --git a/ld/testsuite/ld-scripts/rgn-at11.s b/ld/testsuite/ld-scripts/rgn-at11.s
new file mode 100644
index 0000000..2ec63c8
--- /dev/null
+++ b/ld/testsuite/ld-scripts/rgn-at11.s
@@ -0,0 +1,10 @@
+ .text
+ .zero 16
+
+ .section .tbss,"awT",%nobits
+ .p2align 8
+ .zero 16
+
+ .data
+ .p2align 4
+ .long 0


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]