This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
Have you looked at the testcase I added? Are there anything which are target specific?I do have looked at the testcase, they do be purely C code. If the convention of generic is syntax generic instead of both syntax and sematics, I don't have further comment on this. Anyway, attached patch skips the non-pie version "Mixing PIC and non-PIC" testcase. Not sure if it's trivial enough to qualify obvious, so OK for master branch? 2016-03-02 Jiong Wang <jiong.wang@arm.com> ld/testsuite/ * ld-elf/shared.exp (mix_pic_and_non_pic): Only run on ARM and AArch64 when -fPIE or -fpie specified.That is wrong. If you don't want to see FAIL, you can skip the whole. mix_pic_and_non_pic. Please don't modify mix_pic_and_non_pic.
Then, how about the updated version? 2016-03-02 Jiong Wang <jiong.wang@arm.com> ld/testsuite/ * ld-elf/shared.exp: Skip "Mixing PIC and non-PIC" on ARM and AArch64 if -fpie or -fPIE not specified.
diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp index e615f55..d66fd89 100644 --- a/ld/testsuite/ld-elf/shared.exp +++ b/ld/testsuite/ld-elf/shared.exp @@ -640,5 +640,7 @@ proc mix_pic_and_non_pic {cflags ldflags} { } } -mix_pic_and_non_pic "" "" +if {![istarget arm*-*-*] && ![istarget aarch64*-*-*]} { + mix_pic_and_non_pic "" "" +} mix_pic_and_non_pic "-fPIE" "-pie"
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |