This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [ld/testsuite] Skip "Mixing PIC and non-PIC" testcase on ARM/AArch64 if when no -fpie or -fPIE
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jiong Wang <jiong dot wang at foss dot arm dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Wed, 2 Mar 2016 11:37:19 -0800
- Subject: Re: [ld/testsuite] Skip "Mixing PIC and non-PIC" testcase on ARM/AArch64 if when no -fpie or -fPIE
- Authentication-results: sourceware.org; auth=none
- References: <20160223175814 dot GA2858 at intel dot com> <alpine dot LSU dot 2 dot 20 dot 1602241843180 dot 20277 at wotan dot suse dot de> <CAJimCsG=1u_yM6SBFAxCxB4JvWtxO5fZ22+OmG6UC_RYON3DdA at mail dot gmail dot com> <alpine dot LSU dot 2 dot 20 dot 1602251356320 dot 20277 at wotan dot suse dot de> <CAMe9rOpzw08UPTfjFEhixY=x4je--03ZdsXdrpdS-2sYSxDE3Q at mail dot gmail dot com> <56D5A0D9 dot 5070500 at foss dot arm dot com> <CAMe9rOq_sXd9qccTddvMB8sTBgOPWq0wgiqSQX4iSyUVys4n-Q at mail dot gmail dot com> <56D6D676 dot 5020202 at foss dot arm dot com> <CAMe9rOq__U54POpvUgKrYTinD1J0josM6MWph3d+zGmm=v3rgQ at mail dot gmail dot com> <CAMe9rOq_LZTeC+Zkd6L-o=8Sd=hbvmTDJ+LOCMXfqVAuyU+5CQ at mail dot gmail dot com> <56D6E982 dot 1090607 at foss dot arm dot com> <CAMe9rOptA2-Pc6m6mJzP8=p+kczDe180zLjWOymEicdOxEnP0Q at mail dot gmail dot com> <CAMe9rOo3AYCSfOMue=L_b0k9ORbMOY9ptPEJ4tsyvYdkD21o8Q at mail dot gmail dot com> <56D71011 dot 9040306 at foss dot arm dot com> <CAMe9rOrFr4uaVWpu4OWG_p62=NW4jVnR63qmrs3ho61WVLg2=w at mail dot gmail dot com> <56D72496 dot 4040008 at foss dot arm dot com> <CAMe9rOraeOZ5_jX0zZQVW0CJr=YNVp9aD==7pG3+74GhvQmtAw at mail dot gmail dot com> <56D72B14 dot 5060003 at foss dot arm dot com> <n99si08so1x dot fsf at foss dot arm dot com> <CAMe9rOoUJ84HEg4dQC+7bbfbbsd9CPc5sLC1b--2nL9hf4b1Nw at mail dot gmail dot com> <n99k2lkfzx1 dot fsf at foss dot arm dot com>
On Wed, Mar 2, 2016 at 11:15 AM, Jiong Wang <jiong.wang@foss.arm.com> wrote:
>
> H.J. Lu writes:
>
>>
>> Try this.
>
> LGTM.
>
> Works OK on both AArch64 & ARM native check.
>
I checked in this.
H.J.
---
commit 7494161b47210a94b532a0f98d75e8cb084c21f9
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Wed Mar 2 11:35:03 2016 -0800
Xfail mix_pic_and_non_pic on arm and aarch64
* testsuite/ld-elf/shared.exp (mix_pic_and_non_pic): Add xfails.
Xfail mix_pic_and_non_pic on "arm*-*-*" "aarch64*-*-*".
diff --git a/ld/ChangeLog b/ld/ChangeLog
index e27d5f0..c839971 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,5 +1,10 @@
2016-03-02 H.J. Lu <hongjiu.lu@intel.com>
+ * testsuite/ld-elf/shared.exp (mix_pic_and_non_pic): Add xfails.
+ Xfail mix_pic_and_non_pic on "arm*-*-*" "aarch64*-*-*".
+
+2016-03-02 H.J. Lu <hongjiu.lu@intel.com>
+
PR ld/19739
* emultempl/mmo.em (mmo_place_orphan): Don't merge flags of other
input sections for relocatable link.
diff --git a/ld/testsuite/ld-elf/shared.exp b/ld/testsuite/ld-elf/shared.exp
index e615f55..678ab1b 100644
--- a/ld/testsuite/ld-elf/shared.exp
+++ b/ld/testsuite/ld-elf/shared.exp
@@ -583,7 +583,7 @@ if { [istarget *-*-linux*]
]
}
-proc mix_pic_and_non_pic {cflags ldflags} {
+proc mix_pic_and_non_pic {xfails cflags ldflags} {
set testname "Mixing PIC and non-PIC"
if { ![ string match "" $cflags$ldflags] } {
set testname "$testname ($cflags $ldflags)"
@@ -632,6 +632,10 @@ proc mix_pic_and_non_pic {cflags ldflags} {
exec cp tmpdir/libpr19719a.so tmpdir/libpr19719.so
+ foreach targ $xfails {
+ setup_xfail $targ
+ }
+
set exec_output [run_host_cmd tmpdir/pr19719 ""]
if {![string match "PASS" $exec_output]} {
fail $testname
@@ -640,5 +644,5 @@ proc mix_pic_and_non_pic {cflags ldflags} {
}
}
-mix_pic_and_non_pic "" ""
-mix_pic_and_non_pic "-fPIE" "-pie"
+mix_pic_and_non_pic [list "arm*-*-*" "aarch64*-*-*"] "" ""
+mix_pic_and_non_pic [] "-fPIE" "-pie"